-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition namespaces and providers #473
Conversation
6037ff5
to
c762e33
Compare
I think this is ready for some initial feedback. I've also made the start of a namespace repo at https://github.com/ml-evs/optimade-stability-namespace (currently forked to https://github.com/Materials-Consortia/optimade-stability-namespace) where I am trying to use @rartino's processing tools from #445 to generate the website/schemas (currently with no luck). |
@ml-evs I've gone through this, and aside the minor formatting issue @merkys remarked on (and I've provided a diff for), this looks very good to me and I don't quite see why we cannot already merge it. The new optimade-property-tools repo with its example directory may make it a bit easier to run a namespace provider test. |
Thanks @rartino, happy to merge this before rc.2 so we can test out the implications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. We are already trying this out in other repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some minor suggestions to put definition-provider prefixes to the same level as database-provider prefixes. AFAIK they should be roughly equivalent from now.
d469838
to
12c1d89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-confirming my positive approval.
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
Co-authored-by: Rickard Armiento <gitcommits@armiento.net>
Co-authored-by: Andrius Merkys <andrius.merkys@gmail.com>
12c1d89
to
b71f361
Compare
Ok, now that the one linting issue is fixed (with the checker introduced since your last reviews...) I think this is the final time I need to bother you all with review requests (on this PR...) |
This PR begins the work on #328, adding prefixes that can be shared across providers. I will try to follow this rough plan with my work:
Potentially extend the provider/link definition to add a specialism for this kind of provider(decided against it)Then outside of the specification we need to:
Closes #328