Created Students Show View #64

MatiasMercado · 2017-01-29T17:20:34Z

Students Show View

The view shows a student's detail. It can be access at /students/:docket.
Since student is hard coded, the view can be accessed using any docket.

Trello Card

https://trello.com/c/c16h7OXj/34-maquetar-vista-de-un-alumno

codecov-io · 2017-01-29T17:26:35Z

Codecov Report

Merging #64 into development will increase coverage by 0.16%.

@@               Coverage Diff               @@
##           development      #64      +/-   ##
===============================================
+ Coverage        11.88%   12.04%   +0.16%     
===============================================
  Files               96       97       +1     
  Lines             2626     2631       +5     
  Branches           175      175              
===============================================
+ Hits               312      317       +5     
  Misses            2314     2314

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 452a96f...fcfd4f7. Read the comment docs.

MatiasComercio

Responsive behavior is not working ok. I'll fix this and all index.html related issues for you. You take care of the rest.

MatiasComercio · 2017-01-29T18:31:12Z

app/scripts/controllers/StudentsShowCtrl.js

+'use strict';
+
+define(['paw'], function(paw) {
+  paw.controller('StudentsShowCtrl', ['$routeParams', function($routeParams) {


Fix indentation

MatiasComercio · 2017-01-29T18:32:02Z

app/scripts/controllers/StudentsShowCtrl.js

+'use strict';
+
+define(['paw'], function(paw) {
+  paw.controller('StudentsShowCtrl', ['$routeParams', function($routeParams) {


Nice use of the array and string service injection! 😄

MatiasComercio · 2017-01-29T18:32:06Z

app/scripts/controllers/StudentsShowCtrl.js

+  paw.controller('StudentsShowCtrl', ['$routeParams', function($routeParams) {
+    var _this = this;
+
+    this.docket = $routeParams.docket; // For future Service calls


Perfect! 👍

However, I wouldn't assign this to the controller, but to a variable, as it is not necessary to expose this information to the view.
i.e.:

var docket = $routeParams.docket; // For future Service calls

MatiasComercio · 2017-01-29T18:35:13Z

app/specs/controllers/StudentsShowCtrl.spec.js

+        $controller = _$controller_;
+        controller = $controller('StudentsShowCtrl');
+        expectedStudent =
+        {


Unify style: either you put this { beside the above = or you fix the address: { line

MatiasComercio · 2017-01-29T18:37:43Z

app/specs/controllers/StudentsShowCtrl.spec.js

+
+      it('loads the required student', function() {
+        expect(controller.student).toEqual(expectedStudent);
+      });


Test case missing: you should be testing that the controller's docket is being loaded from the $routeParams service. Take a look at the StudentsIndexCtrl.spec.js from #63

However, if you've changed the docket assignment from this.docket to var docket as suggested above, you won't be able to test the controllers variable (as it is local to that function). What you would have to do is to use a Jasmine Spy and check that the $routeParam.docket is being requested. You can also check other spec files for further help. If you cannot manage it, just tell me.

MatiasComercio · 2017-01-29T18:45:53Z

app/views/students/show.html

+	<!-- Page Heading -->
+	<div class="row">
+		<div class="col-xs-12">
+			<h2 class="page-header">


I know that I've told you to use h2 as a page header in #63, but I made a mistake. Sorry for that. Please update this to h1

MatiasComercio · 2017-01-29T18:46:37Z

app/views/students/show.html

@@ -0,0 +1,125 @@
+<div ng-controller='StudentsShowCtrl as controller'>


Use simple quotes whenever possible. Ask me for private how to do it quickly.

MatiasComercio · 2017-01-29T18:51:44Z

app/views/students/show.html

+	<div class="row">
+		<div class="col-xs-12">
+			<h2 class="page-header">
+        <span translate="i18nStudentsPanelSection"></span>


Try to create another translation with the same text. I know, maybe it sounds kind of weird, but let me explain you.

Your string representing your translation should represent where you will use it, no matter what its text is. So, in this case, I would define a translation
i18nStudents: Alumnos.

Trade off of this option: cleaner and semantic code, and independent key-value translation per view vs. wording repetition.

I'm not even sure why it's there. It should the the student's firstName + lastName.

MatiasComercio · 2017-01-29T18:54:20Z

app/scripts/routes.js

@@ -11,6 +11,10 @@ define([], function() {
            '/login': {
                templateUrl: '/views/login.html',
                controller: 'LoginCtrl'
+            },
+            '/student/:docket': {


This path is not OK. it should be /students/:docket ('s' from students missing)

MatiasComercio

My fixes are pending too. I'll ping you when I've finished

MatiasComercio · 2017-01-30T14:17:55Z

app/specs/controllers/StudentsShowCtrl.spec.js

@@ -12,36 +12,39 @@ function() {
  describe('Students Show Ctrl', function() {
    beforeEach(module('paw'));

-    var $controller, controller, expectedStudent;
+    var expectedStudent = expectedStudent = {


What's this? I haven't seen it before...

I'll change it, but if you intentionally wrote this, please explain it to me.

Sorry, definitely not intentional.

No problem bro! 😄

MatiasMercado requested a review from MatiasComercio January 29, 2017 17:21

MatiasComercio requested changes Jan 29, 2017

View reviewed changes

MatiasComercio requested changes Jan 30, 2017

View reviewed changes

MatiasComercio self-assigned this Jan 30, 2017

MatiasComercio mentioned this pull request Jan 30, 2017

Created Students Update View #67

Merged

MatiasComercio force-pushed the students_show branch from c519f89 to 1bf71da Compare January 30, 2017 19:54

MatiasComercio assigned MatiasMercado and unassigned MatiasComercio Jan 30, 2017

MatiasComercio approved these changes Jan 30, 2017

View reviewed changes

Created Students Show View

fcfd4f7

MatiasMercado force-pushed the students_show branch from 1bf71da to fcfd4f7 Compare January 30, 2017 20:49

MatiasMercado merged commit 0063175 into development Jan 30, 2017

MatiasMercado deleted the students_show branch January 30, 2017 21:36

MatiasComercio mentioned this pull request Feb 5, 2017

Pre-release 2017-02-05 #121

Merged

MatiasComercio pushed a commit that referenced this pull request Feb 5, 2017

Created Students Show View (#64)

490ce2a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Created Students Show View #64

Created Students Show View #64

MatiasMercado commented Jan 29, 2017

codecov-io commented Jan 29, 2017 •

edited

Loading

MatiasComercio left a comment

MatiasComercio Jan 29, 2017

MatiasComercio Jan 29, 2017

MatiasComercio Jan 29, 2017

MatiasComercio Jan 29, 2017

MatiasComercio Jan 29, 2017

MatiasComercio Jan 29, 2017

MatiasComercio Jan 29, 2017

MatiasComercio Jan 29, 2017

MatiasMercado Jan 29, 2017

MatiasComercio Jan 29, 2017

MatiasComercio left a comment

MatiasComercio Jan 30, 2017

MatiasMercado Jan 30, 2017

MatiasComercio Jan 30, 2017

		@@ -0,0 +1,125 @@
		<div ng-controller='StudentsShowCtrl as controller'>

Created Students Show View #64

Created Students Show View #64

Conversation

MatiasMercado commented Jan 29, 2017

Students Show View

Trello Card

codecov-io commented Jan 29, 2017 • edited Loading

Codecov Report

MatiasComercio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MatiasComercio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Jan 29, 2017 •

edited

Loading