Created Students Update View #67

MatiasMercado · 2017-01-30T16:44:30Z

Students Update View

Created the view for updating students.
Changed the view's path from /students/:docket/edit (as it is in the Master version) to /students/:docket/update

Trello Card

https://trello.com/c/upmdEyGZ/36-maquetar-vista-de-edicion-de-alumno

MatiasComercio

Nice work! Only those changes and then I'll give it a try to the view before merging it! 😄

MatiasComercio · 2017-01-30T16:58:02Z

app/scripts/i18n/translations.es.js

    i18nDni: 'DNI',
-    i18Docket: 'Legajo',
+    i18nDocket: 'Legajo',


Sorry for not having seen this before :(

MatiasComercio · 2017-01-30T17:01:10Z

app/scripts/routes.js

@@ -16,6 +16,10 @@ define([], function() {
                templateUrl: 'views/students/index.html',
                controller: 'StudentsIndexCtrl',
                relativePath: '/students'
+            },
+            '/students/:docket/update': {


It should be /students/:docket/edit.
update is the POST action that will be send to the server.

Why have you changed this from the doc? Please fix it also there

Also, rename the controller to be StudentsEditCtrl

I first marked it as conflict, since both StudentsUpdate and StudentsEdit were added to the documentation, but only StudentsUpdate exists in API.
I now deleted the resources marked as conflict, to clear the documentation.
Finally, I changed the view's path to /update to maintain consistency. This last change is of course, not required since API and Front Paths don't need to match.
Why would you choose /edit over /update?

It's just that we've agreed to use Rail's endpoints as a starting point.

I've told you to change it since there the edit's view path is /photos/:id/edit.
It's just fu**ing convention. We should play 'stone, paper or scissors' to define it 😝
What do you say?

Also, I have to admit that I've made a mistake. Note that the update path is /photos/:id with a PATCH/PUT HTTP verb (there is no /update at the end of the URL).
I've noticed that in the documentation we have used a POST verb. @gibarsin would you change it or leave it like that?

MatiasComercio · 2017-01-30T17:02:56Z

app/scripts/routes.js

@@ -16,6 +16,10 @@ define([], function() {
                templateUrl: 'views/students/index.html',
                controller: 'StudentsIndexCtrl',
                relativePath: '/students'
+            },
+            '/students/:docket/update': {
+                templateUrl: '/views/students/update.html',


Note that views are now written without the starting slash. Fix this or it won't work on production environment.

MatiasComercio · 2017-01-30T17:04:16Z

app/scripts/routes.js

+            },
+            '/students/:docket/update': {
+                templateUrl: '/views/students/update.html',
+                controller: 'StudentsUpdateCtrl'


This controller should have set the relativePath: '/students' property, as the other controllers from above. When doing this, you should move this controller to the 'controllers/students' folder, as the others.

Will keep it in mind!

MatiasComercio · 2017-01-30T17:05:32Z

app/styles/modules/common.scss

@@ -83,3 +83,9 @@ hr {
 .btn {
  border-radius: 0;
 }
+
+.full-width-button {


I'll check it later directly on the view

MatiasComercio · 2017-01-30T17:05:54Z

app/styles/partials/students/_update.scss

@@ -0,0 +1,11 @@
+.students-update-container {


Same as above

MatiasComercio · 2017-01-30T17:07:55Z

app/views/students/index.html

          </tr>
          <tr ng-repeat='student in controller.students'>
            <td>{{ student.docket }}</td>
            <td>{{ student.firstName }}</td>
            <td>{{ student.lastName }}</td>
            <td class='actions-container'>
-              <a class='btn btn-default fullWidthButton' role='button'>
+              <a class='btn btn-default full-width-button' role='button'>


Now, reading this, I think that this class (full-width-button) is not necessary, as we are using flex to fill the space depending on the amount of action buttons. I'll check it later.
But good catch with the class name style!

MatiasComercio · 2017-01-30T17:10:42Z

app/views/students/update.html

@@ -0,0 +1,145 @@
+<div ng-controller='StudentsUpdateCtrl as controller' class='students-update-container'>


Once I've finished with the view of #64, we can check it is possible to use that page header style instead of this one. The rest of this style I think it would be OK.

Checking out branch Finished Students Update View Add test & rebased Development Fix bug in test Fix view & controller path in route.js Renamed StudentsUpdateCtrl to StudentsEditCtrl

- Fix edit page header - Update styles - Improve responsive style - Clone show style - Align texts - Style buttons - Fix some styles and translations on views - Add angular-messages dependency for form errors - Add form errors view and style - Add form error messages to all required fields - Fix index filters issue - Add toy update and cancel form functions - Add form validations trigger on submission - Add redirect after successful update - Add return to previous window location when cancel - Add new test cases

* Add students edit view - Finished Students Update View - Add test - Renamed StudentsUpdateCtrl to StudentsEditCtrl - Update styles - Improve responsive style - Clone show style - Align texts - Style buttons - Add angular-messages dependency for form errors - Add form errors view and style - Add form error messages to all required fields - Add toy update and cancel form functions - Add form validations trigger on submission - Add redirect after successful update - Add return to previous window location when cancel - Add new test cases

MatiasMercado requested a review from MatiasComercio January 30, 2017 16:46

MatiasComercio requested changes Jan 30, 2017

View reviewed changes

MatiasComercio assigned MatiasMercado Jan 30, 2017

MatiasMercado force-pushed the students-update-view branch from ff709cb to f57d759 Compare January 30, 2017 19:28

Add students edit view

c3fcd33

Checking out branch Finished Students Update View Add test & rebased Development Fix bug in test Fix view & controller path in route.js Renamed StudentsUpdateCtrl to StudentsEditCtrl

MatiasComercio force-pushed the students-update-view branch from f57d759 to 4a9b20a Compare January 31, 2017 06:30

MatiasComercio force-pushed the students-update-view branch from 4a9b20a to 2cdb557 Compare January 31, 2017 06:45

MatiasComercio approved these changes Jan 31, 2017

View reviewed changes

MatiasMercado merged commit 2af1fc0 into development Jan 31, 2017

MatiasComercio deleted the students-update-view branch February 1, 2017 05:32

MatiasComercio mentioned this pull request Feb 5, 2017

Pre-release 2017-02-05 #121

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Created Students Update View #67

Created Students Update View #67

MatiasMercado commented Jan 30, 2017 •

edited

Loading

MatiasComercio left a comment

MatiasComercio Jan 30, 2017

MatiasComercio Jan 30, 2017

MatiasMercado Jan 30, 2017 •

edited

Loading

MatiasComercio Jan 30, 2017

MatiasComercio Jan 30, 2017

MatiasMercado Jan 30, 2017

MatiasComercio Jan 30, 2017

MatiasMercado Jan 30, 2017

MatiasComercio Jan 30, 2017

MatiasComercio Jan 30, 2017

MatiasComercio Jan 30, 2017 •

edited

Loading

MatiasComercio Jan 30, 2017

		@@ -0,0 +1,145 @@
		<div ng-controller='StudentsUpdateCtrl as controller' class='students-update-container'>

Created Students Update View #67

Created Students Update View #67

Conversation

MatiasMercado commented Jan 30, 2017 • edited Loading

Students Update View

Trello Card

MatiasComercio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MatiasMercado Jan 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MatiasComercio Jan 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MatiasMercado commented Jan 30, 2017 •

edited

Loading

MatiasMercado Jan 30, 2017 •

edited

Loading

MatiasComercio Jan 30, 2017 •

edited

Loading