Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.7.0 #242

Merged
merged 17 commits into from
Feb 27, 2023
Merged

Release 0.7.0 #242

merged 17 commits into from
Feb 27, 2023

Conversation

giffels
Copy link
Member

@giffels giffels commented Apr 19, 2022 •
edited
Loading

This pull request prepares the release of cobald-tardis 0.7.0.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022 •
edited
Loading

Codecov Report

Base: 98.80% // Head: 98.80% // No change to project coverage 👍

Coverage data is based on head (b7792d1) compared to base (61f6f54).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files          56       56           
  Lines        2339     2339           
=======================================
  Hits         2311     2311           
  Misses         28       28
Impacted Files Coverage Δ
tardis/__about__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@giffels giffels force-pushed the release-0.7.0 branch 2 times, most recently from 96b7ec6 to 46415ed Compare February 24, 2023 10:06
giffels
giffels commented Feb 24, 2023
View reviewed changes
docs/source/adapters/site.rst
@@ -199,11 +199,11 @@ Available adapter configuration options
| Option | Short Description | Requirement |
+================+===================================================================================+=================+
| max_age | The result of the `condor_status` call is cached for `max_age` in minutes. | **Required** |
+================+===================================================================================+=================+
+----------------+-----------------------------------------------------------------------------------+-----------------+
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected multiple head/body row separators in the HTCondor site adapter documentation. The table was missing otherwise as it caused an error when building the docs.

giffels
giffels commented Feb 24, 2023
View reviewed changes
docs/source/services/services.rst
@@ -85,10 +85,6 @@ Available configuration options
+----------------+-------------------------------------------------------------------+-----------------+
| port | Port the REST Service is listening on | **Required** |
+----------------+-------------------------------------------------------------------+-----------------+
| secret_key | 32 byte secret key to generate and validate JWTs | **Required** |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed outdated documentation of the REST API. Those parts have been changed in #250, but the documentation has not been updated.

giffels
giffels commented Feb 24, 2023
View reviewed changes
docs/source/services/services.rst
@@ -182,53 +171,6 @@ Available logging configuration options
Convenience Tools
~~~~~~~~~~~~~~~~~

Generate Token
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. generate_token does not exists anymore.

@giffels giffels marked this pull request as ready for review February 24, 2023 15:10
@giffels giffels requested review from a team and maxfischer2781 and removed request for a team February 24, 2023 15:11
maxfischer2781
maxfischer2781 previously approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as a whole.

If you know why some of the changes were reformatted from |-style blocks to \-broken literals, you might want to fix that though. No problem fixing it later or keeping it as-is, though.

eileen-kuehn
eileen-kuehn previously approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

We should maybe take some of your changes as a reminder to better cross-check documentation during reviewing processes 🤔

@giffels
Copy link
Member Author

giffels commented Feb 24, 2023

Looks good to me :)

We should maybe take some of your changes as a reminder to better cross-check documentation during reviewing processes 🤔

Indeed. I reviewed #250. So I missed it. :-/

@giffels
Copy link
Member Author

giffels commented Feb 24, 2023

If you know why some of the changes were reformatted from |-style blocks to \-broken literals, you might want to fix that though. No problem fixing it later or keeping it as-is, though.

I have no idea what caused it. I have fixed it now, could you @eileen-kuehn and @maxfischer2781 reapprove, please?

@giffels giffels added this pull request to the merge queue Feb 27, 2023
Merged via the queue into MatterMiners:master with commit 44725f8 Feb 27, 2023
@giffels giffels deleted the release-0.7.0 branch February 27, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eileen-kuehn eileen-kuehn eileen-kuehn approved these changes

@maxfischer2781 maxfischer2781 maxfischer2781 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giffels @codecov-commenter @maxfischer2781 @eileen-kuehn