Skip to content

Commit

Permalink
gh-512 Markup fix: <th> tags should have "id" or "scope" attributes
Browse files Browse the repository at this point in the history
  • Loading branch information
pjmonks committed Apr 27, 2022
1 parent 29f32fc commit 73eb2c4
Show file tree
Hide file tree
Showing 63 changed files with 288 additions and 272 deletions.
10 changes: 5 additions & 5 deletions src/app/access/group-access-new/group-access-new.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ <h4 class="marginless">
<form>
<table *ngIf="!loading" mat-table [dataSource]="dataSource" matSort class="mdm--mat-table table-striped">
<ng-container matColumnDef="user">
<th mat-header-cell *matHeaderCellDef mat-sort-header>Group name</th>
<th mat-header-cell *matHeaderCellDef mat-sort-header scope="col">Group name</th>
<td mat-cell *matCellDef="let record; let i = index" style="text-align: left; word-wrap: break-word;">
<div *ngIf="!record.inEdit">
{{ record.userGroup.name }}
Expand Down Expand Up @@ -72,7 +72,7 @@ <h4 class="marginless">
</ng-container>

<ng-container matColumnDef="access">
<th mat-header-cell *matHeaderCellDef mat-sort-header>Access Level</th>
<th mat-header-cell *matHeaderCellDef mat-sort-header scope="col">Access Level</th>
<td mat-cell *matCellDef="let record; let i = index" style="text-align: left; word-wrap: break-word;">
<div *ngIf="!record.inEdit">
{{ record.groupRole.displayName }}
Expand Down Expand Up @@ -137,9 +137,9 @@ <h4 class="marginless">
<div class="item" *ngIf="loading">
<table class="mdm--mat-table mdm--skeleton-table">
<tr>
<th style="width: 33.5%;"><ngx-skeleton-loader count="1" [theme]="{'background-color': '#b7bbc5', 'width': '30%'}"></ngx-skeleton-loader></th>
<th style="width: 43%;"><ngx-skeleton-loader count="1" [theme]="{'background-color': '#b7bbc5', 'width': '25%'}"></ngx-skeleton-loader></th>
<th style="width: 11.5%;"><ngx-skeleton-loader count="1" [theme]="{'background-color': '#b7bbc5', 'width': '40%'}"></ngx-skeleton-loader></th>
<th style="width: 33.5%;" scope="col"><ngx-skeleton-loader count="1" [theme]="{'background-color': '#b7bbc5', 'width': '30%'}"></ngx-skeleton-loader></th>
<th style="width: 43%;" scope="col"><ngx-skeleton-loader count="1" [theme]="{'background-color': '#b7bbc5', 'width': '25%'}"></ngx-skeleton-loader></th>
<th style="width: 11.5%;" scope="col"><ngx-skeleton-loader count="1" [theme]="{'background-color': '#b7bbc5', 'width': '40%'}"></ngx-skeleton-loader></th>
</tr>
<tr>
<td><ngx-skeleton-loader count="1" appearance="line"></ngx-skeleton-loader></td>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ <h4 class="marginless">
<div class="table-responsive">
<table mat-table [dataSource]="dataSource" matSort class="mdm--mat-table table table-striped marginless">
<ng-container matColumnDef="key">
<th mat-header-cell *matHeaderCellDef mat-sort-header style="cursor: pointer; max-width: 40%;" columnName="key">
<th mat-header-cell *matHeaderCellDef mat-sort-header style="cursor: pointer; max-width: 40%;" columnName="key" scope="col">
<span>Key</span>
</th>
<td mat-cell *matCellDef="let record" style="text-align: left; word-wrap: break-word;">
Expand All @@ -52,15 +52,15 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="category">
<th mat-header-cell *matHeaderCellDef mat-sort-header style="cursor: pointer; max-width: 40%;" columnName="category">
<th mat-header-cell *matHeaderCellDef mat-sort-header style="cursor: pointer; max-width: 40%;" columnName="category" scope="col">
<span>Category</span>
</th>
<td mat-cell *matCellDef="let record" style="text-align: left; word-wrap: break-word;">
<span>{{record.metadata.category}}</span>
</td>
</ng-container>
<ng-container matColumnDef="value">
<th mat-header-cell *matHeaderCellDef mat-sort-header style="cursor: pointer; max-width: 40%;" columnName="value">
<th mat-header-cell *matHeaderCellDef mat-sort-header style="cursor: pointer; max-width: 40%;" columnName="value" scope="col">
<span>Value</span>
</th>
<td mat-cell *matCellDef="let record" style="text-align: left; word-wrap: break-word;">
Expand Down
10 changes: 5 additions & 5 deletions src/app/admin/emails/emails.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ <h4 class="marginless">
<div class="table-responsive">
<table mat-table matSort [dataSource]="records" class="mdm--mat-table table table-striped marginless">
<ng-container matColumnDef="sentToEmailAddress">
<th mat-header-cell *matHeaderCellDef mat-sort-header="sentToEmailAddress" [disabled]="!hideFilters" style="cursor: pointer; width: 20%" columnName="sentToEmailAddress">
<th mat-header-cell *matHeaderCellDef mat-sort-header="sentToEmailAddress" [disabled]="!hideFilters" style="cursor: pointer; width: 20%" columnName="sentToEmailAddress" scope="col">
<span [hidden]="!hideFilters">To</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" floatLabel="never">
Expand All @@ -40,7 +40,7 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="dateTimeSent">
<th mat-header-cell *matHeaderCellDef mat-sort-header="dateTimeSent" [disabled]="!hideFilters" style="cursor: pointer; width: 10%;" columnName="dateTimeSent">
<th mat-header-cell *matHeaderCellDef mat-sort-header="dateTimeSent" [disabled]="!hideFilters" style="cursor: pointer; width: 10%;" columnName="dateTimeSent" scope="col">
<span>Date/Time</span>
</th>
<td mat-cell *matCellDef="let record" style="text-align: left; word-wrap: break-word;">
Expand All @@ -49,7 +49,7 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="subject">
<th mat-header-cell *matHeaderCellDef mat-sort-header="subject" [disabled]="!hideFilters" style="cursor: pointer; width: 20%;" columnName="subject">
<th mat-header-cell *matHeaderCellDef mat-sort-header="subject" [disabled]="!hideFilters" style="cursor: pointer; width: 20%;" columnName="subject" scope="col">
<span [hidden]="!hideFilters">Subject</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" floatLabel="never">
Expand All @@ -64,15 +64,15 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="body">
<th mat-header-cell *matHeaderCellDef mat-sort-header="body" [disabled]="!hideFilters" style="cursor: pointer; width:40%" columnName="body">
<th mat-header-cell *matHeaderCellDef mat-sort-header="body" [disabled]="!hideFilters" style="cursor: pointer; width:40%" columnName="body" scope="col">
<span>Body</span>
</th>
<td mat-cell *matCellDef="let record" style="text-align: left; word-wrap: break-word;">
<mdm-more-description [description]="record.body" [length]="200"></mdm-more-description>
</td>
</ng-container>
<ng-container matColumnDef="successfullySent">
<th mat-header-cell *matHeaderCellDef mat-sort-header="successfullySent" [disabled]="!hideFilters" style="cursor: pointer; width: 10%;" columnName="successfullySent">
<th mat-header-cell *matHeaderCellDef mat-sort-header="successfullySent" [disabled]="!hideFilters" style="cursor: pointer; width: 10%;" columnName="successfullySent" scope="col">
<span [hidden]="!hideFilters">Status</span>
</th>
<td mat-cell *matCellDef="let record" style="text-align: left;">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ <h4 class="marginless">
<div class="table-responsive">
<table mat-table matSort #table [dataSource]="records" class="mdm--mat-table table-striped marginless">
<ng-container matColumnDef="disabled">
<th mat-header-cell *matHeaderCellDef style="cursor:pointer;max-width: 3%;width: 3%;text-align: center;">
<th mat-header-cell *matHeaderCellDef style="cursor:pointer;max-width: 3%;width: 3%;text-align: center;" scope="col">
Status
</th>
<td mat-cell *matCellDef="let record" style="text-align: center;">
Expand All @@ -44,7 +44,7 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="emailAddress">
<th mat-header-cell *matHeaderCellDef style="cursor:pointer;max-width: 3%;width: 3%;text-align: left;">
<th mat-header-cell *matHeaderCellDef style="cursor:pointer;max-width: 3%;width: 3%;text-align: left;" scope="col">
Email
</th>
<td mat-cell *matCellDef="let record">
Expand Down Expand Up @@ -73,7 +73,7 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="fullName">
<th mat-header-cell *matHeaderCellDef style="cursor:pointer;max-width: 3%;width: 3%;text-align: left;">
<th mat-header-cell *matHeaderCellDef style="cursor:pointer;max-width: 3%;width: 3%;text-align: left;" scope="col">
Full name
</th>
<td mat-cell *matCellDef="let record">
Expand Down
4 changes: 2 additions & 2 deletions src/app/admin/groups-table/groups-table.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ <h4 class="marginless">
<div class="table-responsive">
<table mat-table [dataSource]="dataSource" matSort class="mdm--mat-table table table-striped marginless">
<ng-container matColumnDef="name">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters" style="cursor: pointer; max-width: 40%;" columnName="name">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters" style="cursor: pointer; max-width: 40%;" columnName="name" scope="col">
<span [hidden]="!hideFilters">Name</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" floatLabel="never">
Expand All @@ -47,7 +47,7 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="description">
<th mat-header-cell *matHeaderCellDef columnName="description" style="max-width: 50%;">
<th mat-header-cell *matHeaderCellDef columnName="description" style="max-width: 50%;" scope="col">
<span [hidden]="!hideFilters">Description</span>
</th>
<td mat-cell *matCellDef="let record" style="text-align: left; word-wrap: break-word;">
Expand Down
20 changes: 10 additions & 10 deletions src/app/admin/home/active-sessions/active-sessions.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ <h4 class="marginless">
<table mat-table matSort [dataSource]="dataSource" class="mdm--mat-table table table-striped marginless">
<ng-container matColumnDef="userEmailAddress">
<th mat-header-cell *matHeaderCellDef mat-sort-header="userEmailAddress" [disabled]="!hideFilters"
style="cursor: pointer; max-width: 35%; width: 35%;" columnName="userEmailAddress">
style="cursor: pointer; max-width: 35%; width: 35%;" columnName="userEmailAddress" scope="col">
<span [hidden]="!hideFilters">Email</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" floatLabel="never">
Expand All @@ -45,7 +45,7 @@ <h4 class="marginless">
</ng-container>
<ng-container matColumnDef="userName">
<th mat-header-cell *matHeaderCellDef mat-sort-header="userName" [disabled]="!hideFilters"
style="cursor: pointer; max-width: 20%; width: 20%;" columnName="userName">
style="cursor: pointer; max-width: 20%; width: 20%;" columnName="userName" scope="col">
<span [hidden]="!hideFilters">Name</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" [style.width.px]="100" floatLabel="never">
Expand All @@ -63,7 +63,7 @@ <h4 class="marginless">
</ng-container>
<ng-container matColumnDef="userOrganisation">
<th mat-header-cell *matHeaderCellDef mat-sort-header="userOrganisation" [disabled]="!hideFilters"
style="cursor: pointer; max-width: 22%; width: 22%;" columnName="userOrganisation">
style="cursor: pointer; max-width: 22%; width: 22%;" columnName="userOrganisation" scope="col">
<span [hidden]="!hideFilters">Organisation</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" [style.width.px]="100" floatLabel="never">
Expand All @@ -81,7 +81,7 @@ <h4 class="marginless">
</ng-container>
<ng-container matColumnDef="start">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters"
style="cursor: pointer; max-width: 10%; width: 10%;" columnName="start">
style="cursor: pointer; max-width: 10%; width: 10%;" columnName="start" scope="col">
<span [hidden]="!hideFilters">Start</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" [style.width.px]="100" floatLabel="never">
Expand All @@ -102,7 +102,7 @@ <h4 class="marginless">
</ng-container>
<ng-container matColumnDef="lastAccess">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters"
style="cursor: pointer; max-width: 20%; width: 20%;" columnName="lastAccess">
style="cursor: pointer; max-width: 20%; width: 20%;" columnName="lastAccess" scope="col">
<span [hidden]="!hideFilters">Last Access</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" [style.width.px]="100" floatLabel="never">
Expand All @@ -122,7 +122,7 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="lastAccessedUrl">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters" style="cursor: pointer; max-width: 20%; width: 20%;" columnName="lastAccessedUrl">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters" style="cursor: pointer; max-width: 20%; width: 20%;" columnName="lastAccessedUrl" scope="col">
<span [hidden]="!hideFilters">Last Access URL</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" [style.width.px]="100" floatLabel="never">
Expand Down Expand Up @@ -151,7 +151,7 @@ <h4 class="marginless">
<div class="table-responsive">
<table mat-table matSort [dataSource]="unauthorised" class="mdm--mat-table table table-striped marginless">
<ng-container matColumnDef="id">
<th mat-header-cell *matHeaderCellDef mat-sort-header="id" [disabled]="!hideFilters" style="cursor: pointer; max-width: 35%; width: 35%;" columnName="id">
<th mat-header-cell *matHeaderCellDef mat-sort-header="id" [disabled]="!hideFilters" style="cursor: pointer; max-width: 35%; width: 35%;" columnName="id" scope="col">
<span [hidden]="!hideFilters">Session Id</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" floatLabel="never">
Expand All @@ -168,7 +168,7 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="start">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters" style="cursor: pointer; max-width: 10%; width: 10%;" columnName="start">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters" style="cursor: pointer; max-width: 10%; width: 10%;" columnName="start" scope="col">
<span [hidden]="!hideFilters">Start</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" [style.width.px]="100" floatLabel="never">
Expand All @@ -187,7 +187,7 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="lastAccess">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters" style="cursor: pointer; max-width: 20%; width: 20%;" columnName="lastAccess">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters" style="cursor: pointer; max-width: 20%; width: 20%;" columnName="lastAccess" scope="col">
<span [hidden]="!hideFilters">Last Access</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" [style.width.px]="100" floatLabel="never">
Expand All @@ -206,7 +206,7 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="lastAccessedUrl">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters" style="cursor: pointer; max-width: 20%; width: 20%;" columnName="lastAccessedUrl">
<th mat-header-cell *matHeaderCellDef mat-sort-header [disabled]="!hideFilters" style="cursor: pointer; max-width: 20%; width: 20%;" columnName="lastAccessedUrl" scope="col">
<span [hidden]="!hideFilters">Last Access URL</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" [style.width.px]="100" floatLabel="never">
Expand Down
4 changes: 2 additions & 2 deletions src/app/admin/home/modules/modules.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ <h4 class="marginless">
<div class="table-responsive">
<table mat-table matSort [dataSource]="dataSource" class="mdm--mat-table table table-striped marginless">
<ng-container matColumnDef="name">
<th mat-header-cell *matHeaderCellDef mat-sort-header="name" [disabled]="!hideFilters" style="cursor: pointer; max-width: 78%; width: 78%;" columnName="name">
<th mat-header-cell *matHeaderCellDef mat-sort-header="name" [disabled]="!hideFilters" style="cursor: pointer; max-width: 78%; width: 78%;" columnName="name" scope="col">
<span [hidden]="!hideFilters">Name</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" [style.width.px]="100" floatLabel="never">
Expand All @@ -39,7 +39,7 @@ <h4 class="marginless">
</td>
</ng-container>
<ng-container matColumnDef="version">
<th mat-header-cell *matHeaderCellDef mat-sort-header="version" [disabled]="!hideFilters" style="cursor: pointer; max-width: 22%; width: 22%;" columnName="version">
<th mat-header-cell *matHeaderCellDef mat-sort-header="version" [disabled]="!hideFilters" style="cursor: pointer; max-width: 22%; width: 22%;" columnName="version" scope="col">
<span [hidden]="!hideFilters">Version</span>
<div [hidden]="hideFilters">
<mat-form-field class="filter" [style.width.px]="100" floatLabel="never">
Expand Down
Loading

0 comments on commit 73eb2c4

Please sign in to comment.