Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonarqube issue cleanup #512

Closed
5 of 6 tasks
pjmonks opened this issue Apr 27, 2022 · 1 comment · Fixed by #513
Closed
5 of 6 tasks

Sonarqube issue cleanup #512

pjmonks opened this issue Apr 27, 2022 · 1 comment · Fixed by #513
Assignees
@pjmonks
Labels
clean up Consolidation after new features, refactoring, remove redundant code etc maintenance General maintenance on this repo or application
Milestone
7.1.0

Comments

@pjmonks
Copy link
Contributor

pjmonks commented Apr 27, 2022 •
edited
Loading

The Sonarqube report suggests a lot of issues that could be rectified for code quality and vulnerabilities. Here is the report:

Bugs found: https://jenkins.cs.ox.ac.uk/sonarqube/project/issues?id=mdm-ui&resolved=false&types=BUG

Security hotspots: https://jenkins.cs.ox.ac.uk/sonarqube/security_hotspots?id=mdm-ui

Clean up the following:

Security hotspots

  • All security hotspots should be removed (currently only 3)

Critical bugs

  • Remove all critical issues found. These relate to non-standard CSS selectors.

Other issues

  • Major - <th> tags should have "id" or "scope" attributes
  • Major - 'this.dataClassRecords' is assigned to itself.
  • Minor - <strong> and <em> tags should be used (relates to fontawesome icons)
  • Minor - <table> tags should have a description

After these, review any remaining issues left.
@pjmonks pjmonks added clean up Consolidation after new features, refactoring, remove redundant code etc maintenance General maintenance on this repo or application labels Apr 27, 2022
@pjmonks pjmonks self-assigned this Apr 27, 2022
@pjmonks pjmonks moved this to Backlog in MDM State Apr 27, 2022
@pjmonks pjmonks moved this from Backlog to In Progress in MDM State Apr 27, 2022
pjmonks added a commit that referenced this issue Apr 27, 2022
@pjmonks
gh-512 Temp Jenkinsfile change to run Sonarqube
226153d
pjmonks added a commit that referenced this issue Apr 27, 2022
@pjmonks
gh-512 Add rel=noopener on a tags
fd580e1
pjmonks added a commit that referenced this issue Apr 27, 2022
@pjmonks
gh-512 Remove non-standard CSS selectors
29f32fc 
* Update all CSS to not refer to Angular component names as CSS selectors
* Created mdm-skeleton-badge component to reduce same copy-paste code
@pjmonks pjmonks mentioned this issue Apr 27, 2022
Merged
pjmonks added a commit that referenced this issue Apr 27, 2022
@pjmonks
gh-512 Markup fix: <th> tags should have "id" or "scope" attributes
73eb2c4
pjmonks added a commit that referenced this issue Apr 28, 2022
@pjmonks
gh-512 Fix code that assigns itself
4318068
pjmonks added a commit that referenced this issue Apr 28, 2022
@pjmonks
gh-512 eslint fixes
0c09a70
pjmonks added a commit that referenced this issue Apr 28, 2022
@pjmonks
gh-512 Update all tags that use fontawesome to spans
8e0f2db 
Using `<i>` tag conveys stylist meaning and doesn't convey semantics for browsers
pjmonks added a commit that referenced this issue Apr 28, 2022
@pjmonks
gh-512 Replace remaining fontawesome tags
7a3b250
pjmonks added a commit that referenced this issue Apr 28, 2022
@pjmonks
gh-512 Revert Jenkinsfile back to original
931b1e4
@pjmonks pjmonks moved this from In Progress to Open PR in MDM State Apr 28, 2022
@pjmonks
Copy link
Contributor Author

pjmonks commented Apr 28, 2022

Remaining issues are "Add a description to this table", which are classified by Sonarqube as minor bugs. Agreed that these can be sorted out another time.

olliefreeman added a commit that referenced this issue Apr 28, 2022
@olliefreeman
Merge pull request #513 from MauroDataMapper/feature/gh-512
c71fdae 
#512 Resolution to Sonarqube issues
Repository owner moved this from Open PR to Merged to Develop / Waiting to release in MDM State Apr 28, 2022
@pjmonks pjmonks added this to the 7.1.0 milestone Apr 29, 2022
@joe-crawford joe-crawford moved this from Merged to Develop / Waiting to release to Released in MDM State Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjmonks pjmonks

Labels
clean up Consolidation after new features, refactoring, remove redundant code etc maintenance General maintenance on this repo or application
Projects
MDM State
Status: Released
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

#512 Resolution to Sonarqube issues MauroDataMapper/mdm-ui
1 participant
@pjmonks