Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change permissions on a finalised model #245

Closed
jamesrwelch opened this issue Jul 22, 2021 · 1 comment · Fixed by #256
Closed

Cannot change permissions on a finalised model #245

jamesrwelch opened this issue Jul 22, 2021 · 1 comment · Fixed by #256
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@jamesrwelch
Copy link
Contributor

Describe the bug
The 'Add Group' button does not appear on the permissions modal window when viewing a finalised model.
I believe any changes to the 'publicly readable' and 'readable by authenticated users' are also not persisted.

Expected Behaviour
You should be able to change the permissions of a finalised model.

@jamesrwelch jamesrwelch added the bug Something isn't working label Jul 22, 2021
@pjmonks
Copy link
Contributor

pjmonks commented Jul 27, 2021

For comparison, here is what the group permissions looks like for a draft data model:

image

This is what it looks like for a finalised one:

image

So the "Add Group" button is definitely missing and should be put back somehow.

@pjmonks pjmonks added the good first issue Good for newcomers label Jul 27, 2021
@pjmonks pjmonks self-assigned this Jul 28, 2021
jamesrwelch added a commit that referenced this issue Jul 30, 2021
#245 Allow user groups to be added to finalised models
@pjmonks pjmonks added this to the 6.4.0 milestone Jul 30, 2021
joe-crawford added a commit that referenced this issue Jul 25, 2022
gh-245 Restrict ability to create folders and classifiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants