Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#245 Allow user groups to be added to finalised models #256

Merged
merged 1 commit into from
Jul 30, 2021
Merged

#245 Allow user groups to be added to finalised models #256

merged 1 commit into from
Jul 30, 2021

Conversation

pjmonks
Copy link
Contributor

@pjmonks pjmonks commented Jul 28, 2021

Fixes #245

@pjmonks pjmonks requested a review from jamesrwelch July 28, 2021 15:48
@jamesrwelch
Copy link
Contributor

This looks simple enough, but for some reason a test is failing. Just a question of re-running?

@pjmonks
Copy link
Contributor Author

pjmonks commented Jul 29, 2021

@jamesrwelch It's the Jenkins build being funny, it does that sometimes. Nothing is wrong with the branch, all passes now.

jamesrwelch
jamesrwelch approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@jamesrwelch jamesrwelch merged commit 514957b into develop Jul 30, 2021
@pjmonks pjmonks deleted the feature/gh-245 branch August 16, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrwelch jamesrwelch jamesrwelch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot change permissions on a finalised model
2 participants
@pjmonks @jamesrwelch