Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The jodit configuration in angular.json seems to have no effect. #316

Closed
atpw25 opened this issue Sep 14, 2021 · 1 comment · Fixed by #454
Closed

The jodit configuration in angular.json seems to have no effect. #316

atpw25 opened this issue Sep 14, 2021 · 1 comment · Fixed by #454
Assignees
@abwilson23
Labels
clean up Consolidation after new features, refactoring, remove redundant code etc
Milestone
7.1.0

Comments

@atpw25
Copy link
Contributor

atpw25 commented Sep 14, 2021

The jodit-editor component from jodit-angular package seem to work with or without this configuration in angular.json. Maybe it should be removed?

...
"styles": [
    "src/styles.scss",
    "node_modules/jodit/build/jodit.min.css"
],
"scripts": [
    "node_modules/jodit/build/jodit.min.js"
],
...
@atpw25 atpw25 added the clean up Consolidation after new features, refactoring, remove redundant code etc label Sep 14, 2021
@abwilson23 abwilson23 self-assigned this Jan 31, 2022
abwilson23 added a commit that referenced this issue Feb 1, 2022
@abwilson23
#316 remove unnecessary jodit references. no detected changes once re…
a9485b5 
…moved.
abwilson23 added a commit that referenced this issue Feb 1, 2022
@abwilson23
#316 modify README.md for clarity. install angular/cli globally becau…
8b04619 
…se it adds command line tools.
@pjmonks pjmonks linked a pull request Feb 11, 2022 that will close this issue
Resolve #316 by removing unnecessary jodit references from angular.json and update README #454
Merged
@pjmonks
Copy link
Contributor

pjmonks commented Feb 11, 2022

@abwilson23 also found another issue with the Jodit editor when switching to full screen. As this is separate, issue #453 was created to tackle separately.

pjmonks added a commit that referenced this issue Feb 11, 2022
@pjmonks
Merge pull request #454 from MauroDataMapper/feature/gh-316
f1051fa 
Resolve #316 by removing unnecessary jodit references from angular.json and update README
@pjmonks pjmonks added this to the 7.1.0 milestone Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abwilson23 abwilson23

Labels
clean up Consolidation after new features, refactoring, remove redundant code etc
Projects
None yet
Milestone
7.1.0
3 participants
@pjmonks @atpw25 @abwilson23