Resolve #316 by removing unnecessary jodit references from angular.json and update README #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se it adds command line tools.
|
|
abwilson23
changed the title
pjmonks
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App function was tested with and without the jodit references in angular.json. Proper functionality was present in both cases.
The only notable difference was that including the references resulted in the jodit stylesheet being loaded from the get go (home page), whereas without the references it was added dynamically upon first opening an editor that uses jodit.
Update README.md to include a global flag during installation of angular/cli. This is because global installations are generally preferred when the package offers additional command line functionality.