Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indistinguishable dynamic profiles when viewing #493

Closed
joe-crawford opened this issue Mar 14, 2022 · 1 comment · Fixed by #494
Closed

Indistinguishable dynamic profiles when viewing #493

joe-crawford opened this issue Mar 14, 2022 · 1 comment · Fixed by #494
Assignees
@joe-crawford
Labels
bug Something isn't working

Comments

@joe-crawford
Copy link
Contributor

Description

Similar to #402 (when editing), when viewing a dynamic profile with multiple versions on a data model, the versions are indistinguishable.

Steps to reproduce

  1. Using the UI, create a dynamic profile specification model and finalise (to create version 1.0.0).
  2. Create a new version of the dynamic profile specification model from 1. and finalise again (to create version 2.0.0).
  3. Create a data model and apply one of the dynamic profile versions.
  4. When viewing the data model, in the profile dropdown, the two dynamic profile versions are indistinguishable.

Expected behavior

If multiple profile versions are shown when viewing a datamodel, the version number should be included (as it is when adding a profile after PR #450).

Environment

Desktop

Please complete the following information:

  • OS: macOS
  • Browser: Chrome 99
  • Mauro: latest develop of core, ui and resources

Additional context

N.B. viewing multiple profile versions using develop of mdm-core may be affected by MauroDataMapper/mdm-core#292 if there is a non-finalised profile specification model version.
@joe-crawford joe-crawford added the bug Something isn't working label Mar 14, 2022
@joe-crawford joe-crawford self-assigned this Mar 16, 2022
@joe-crawford
Copy link
Contributor Author

Also change the View/Edit and Add New profile dropdowns to only show the latest (finalised) versions of profiles.

joe-crawford added a commit that referenced this issue Mar 16, 2022
@joe-crawford
Restrict view/edit and add new profile dropdowns to default profile v…
cb9eac0 
…ersions only

- Resolves gh-493
joe-crawford added a commit that referenced this issue Mar 16, 2022
@joe-crawford
Restrict view/edit and add new profile dropdowns to default profile v…
c5c5d14 
…ersions only

- Resolves gh-493
@joe-crawford joe-crawford mentioned this issue Mar 17, 2022
Merged
joe-crawford added a commit that referenced this issue Mar 22, 2022
@joe-crawford
gh-493 Distinguish/restrict profile versions
28cce28 
- Restrict the add new profile dropdown to default (latest) version of profile only
- Show all available versions of profile in view/edit dropdown with version number
joe-crawford added a commit that referenced this issue Mar 22, 2022
@joe-crawford
gh-493 Use default backend filtering in view/add profile dropdowns
e68bce5
joe-crawford added a commit that referenced this issue Mar 25, 2022
@joe-crawford
gh-493 Use default backend filtering in view/add profile dropdowns
3aeaab2 
- Filtering of used/unused profile lists is performed by backend defaults
- Show profile version number in view/edit dropdown
- Use version when saving/validating profile data
joe-crawford added a commit that referenced this issue Mar 28, 2022
@joe-crawford
gh-493 Use default backend filtering in view/add profile dropdowns
6ef9e88 
- Filtering of used/unused profile lists is performed by backend defaults
- Show profile version number in view/edit dropdown
- Use version when saving/validating profile data
jamesrwelch added a commit that referenced this issue Apr 3, 2022
@jamesrwelch
Merge branch 'develop' into feature/gh-493
8aecd6b
jamesrwelch added a commit that referenced this issue Apr 4, 2022
@jamesrwelch
Merge branch 'develop' into feature/gh-493
131a26a
jamesrwelch added a commit that referenced this issue Apr 4, 2022
@jamesrwelch
Merge pull request #494 from MauroDataMapper/feature/gh-493
f3e049e 
Show version numbers in view/edit profiles dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe-crawford joe-crawford

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show version numbers in view/edit profiles dropdown MauroDataMapper/mdm-ui
1 participant
@joe-crawford