Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show version numbers in view/edit profiles dropdown #494

Merged
merged 5 commits into from
Apr 4, 2022
Merged

Show version numbers in view/edit profiles dropdown #494

merged 5 commits into from
Apr 4, 2022

Conversation

joe-crawford
Copy link
Contributor

@joe-crawford joe-crawford commented Mar 17, 2022 •
edited
Loading

Add version number to profile view/edit dropdown and allow backend to filter versions of profiles displayed (resolves gh-493)

@joe-crawford joe-crawford marked this pull request as draft March 17, 2022 09:45
@joe-crawford joe-crawford marked this pull request as ready for review March 17, 2022 10:30
@joe-crawford joe-crawford requested a review from pjmonks March 17, 2022 10:30
@joe-crawford joe-crawford marked this pull request as draft March 17, 2022 10:57
@joe-crawford joe-crawford force-pushed the feature/gh-493 branch 2 times, most recently from e68bce5 to 3aeaab2 Compare March 25, 2022 11:09
@joe-crawford
gh-493 Use default backend filtering in view/add profile dropdowns
6ef9e88 
- Filtering of used/unused profile lists is performed by backend defaults
- Show profile version number in view/edit dropdown
- Use version when saving/validating profile data
@joe-crawford joe-crawford mentioned this pull request Mar 28, 2022
Merged
@joe-crawford
Copy link
Contributor Author

Depends on MauroDataMapper/mdm-resources#56.

Also depends on MauroDataMapper/mdm-core#293 (merged to develop).

@joe-crawford joe-crawford marked this pull request as ready for review March 28, 2022 12:56
@joe-crawford joe-crawford changed the title Only show latest version of profiles in dropdowns Show version numbers in view/edit profiles dropdown Mar 28, 2022
jamesrwelch
jamesrwelch requested changes Apr 3, 2022
View reviewed changes
Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that seems to have stopped working with this commit... is that when you add a new profile, it doesn't properly route the next page to display the new profile properly... Are you able to reproduce this and work out this issue?

@joe-crawford joe-crawford force-pushed the feature/gh-493 branch 2 times, most recently from 0b27cfb to ff86ff1 Compare April 3, 2022 19:27
@joe-crawford
Resolve gh-503
ff86ff1 
- Don't revert to default profile after add/editing profile
- Handle deleting default profile
- Allow empty used profiles list
@joe-crawford
Copy link
Contributor Author

joe-crawford commented Apr 3, 2022 •
edited
Loading

One thing that seems to have stopped working with this commit... is that when you add a new profile, it doesn't properly route the next page to display the new profile properly... Are you able to reproduce this and work out this issue?

Yes I had noticed similar issues, although I think they were already occurring on develop branch (raised as gh-503). Looking again I have realised it is related to how the new configurable default profile is set. The above commit resolves it for me however as the issue was sometimes intermittent, could you check if this resolves it for you?

@joe-crawford
Copy link
Contributor Author

joe-crawford commented Apr 4, 2022 •
edited
Loading

Commit 25bdaf7 contains a change to gh-350 Default dynamic profile view configuration:

The API property to set is still ui.default.profile.namespace; it must be publicly readable.

As the profile display names may not be unique, the default profiles are now set by:

namespace key value example value
value of ui.default.profile.namespace namespace profile provider namespace uk.ac.ox.softeng.maurodatamapper.profile.provider
value of ui.default.profile.namespace name profile provider name A%20Dynamic%20Profile
value of ui.default.profile.namespace version profile provider version 1.0.0

@joe-crawford joe-crawford force-pushed the feature/gh-493 branch 2 times, most recently from 1679506 to ccf110a Compare April 4, 2022 16:23
@joe-crawford
Profile UI fixes
25bdaf7 
- Use fieldTotal and metadataPropertyName values when handling profile errors (part of mc-9719)
- Reset profile values after cancelling adding or editing a profile (resolves gh-502)
- Fix to gh-350 to get default profiles from hierarchy (e.g. set class default from model)
- Change to gh-350 to set default profile by unique namespace, name and version
@joe-crawford joe-crawford requested a review from jamesrwelch April 4, 2022 16:45
jamesrwelch
jamesrwelch approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, well done!

@jamesrwelch jamesrwelch merged commit f3e049e into develop Apr 4, 2022
@jamesrwelch jamesrwelch deleted the feature/gh-493 branch April 4, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrwelch jamesrwelch jamesrwelch approved these changes

@pjmonks pjmonks Awaiting requested review from pjmonks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indistinguishable dynamic profiles when viewing
2 participants
@joe-crawford @jamesrwelch