Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate static test functions & wrappers #23

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Generate static test functions & wrappers #23

merged 2 commits into from
Aug 13, 2024

Conversation

misch7
Copy link
Contributor

@misch7 misch7 commented Jun 5, 2024

Fix missing-prototype errors in mbedtls/tests/suites

Required for: Mbed-TLS/mbedtls#9189

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jun 5, 2024
@gilles-peskine-arm gilles-peskine-arm added priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Jun 5, 2024
@misch7 misch7 mentioned this pull request Jun 5, 2024
Merged
5 tasks
gilles-peskine-arm
gilles-peskine-arm previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

misch7 added a commit to misch7/mbedtls that referenced this pull request Jun 5, 2024
@misch7
Update the submodule to the head of PR in the framework repository (f…
5e94ee0 
…or the CI build)

See Mbed-TLS/mbedtls-framework#23

Signed-off-by: Michael Schuster <michael@schuster.ms>
misch7 added a commit to misch7/mbedtls that referenced this pull request Jun 7, 2024
@misch7
Update the submodule to the head of PR in the framework repository (f…
d4a90bf 
…or the CI build)

See Mbed-TLS/mbedtls-framework#23

Update unit test for generate_test_code.py to take static test functions & wrappers into account

Signed-off-by: Michael Schuster <michael@schuster.ms>
misch7 added a commit to misch7/mbedtls that referenced this pull request Jun 11, 2024
@misch7
Update the submodule to the head of PR in the framework repository
10462d9 
See Mbed-TLS/mbedtls-framework#23

Signed-off-by: Michael Schuster <michael@schuster.ms>
@minosgalanakis minosgalanakis self-requested a review July 16, 2024 13:05
minosgalanakis
minosgalanakis reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, minor comments on the void-> static void substitution. I will happily approve if second reviewer is ok with present state of PR>

scripts/generate_test_code.py Show resolved Hide resolved
@misch7 misch7 force-pushed the mbedtls-pr-9189 branch from 31b66dc to 8a8efd9 Compare July 18, 2024 15:36
misch7 added a commit to misch7/mbedtls that referenced this pull request Jul 18, 2024
@misch7
Update the submodule to the head of PR in the framework repository
3236dd9 
See Mbed-TLS/mbedtls-framework#23

Signed-off-by: Michael Schuster <michael@schuster.ms>
@misch7 misch7 requested a review from minosgalanakis July 18, 2024 15:59
@minosgalanakis
Copy link
Contributor

@misch7 we recently merged a major/significant pr #37 on the framework. Could you please rebase this one on top of it?

Main Repository PR 9189 will also need to have the farmework pointer updated to target the post rebase target of this PR.

@misch7 misch7 force-pushed the mbedtls-pr-9189 branch from 8a8efd9 to d4177eb Compare July 24, 2024 16:09
misch7 added a commit to misch7/mbedtls that referenced this pull request Jul 24, 2024
@misch7
Update the submodule to the head of PR in the framework repository
58e2ebc 
See Mbed-TLS/mbedtls-framework#23

Signed-off-by: Michael Schuster <michael@schuster.ms>
@misch7
Copy link
Contributor Author

misch7 commented Jul 24, 2024

@misch7 we recently merged a major/significant pr #37 on the framework. Could you please rebase this one on top of it?

Main Repository PR 9189 will also need to have the farmework pointer updated to target the post rebase target of this PR.

@minosgalanakis Done and I've also resolved the new merge conflicts in the main repo.

minosgalanakis
minosgalanakis approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gilles-peskine-arm
gilles-peskine-arm approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebase

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jul 25, 2024
minosgalanakis pushed a commit to minosgalanakis/mbedtls that referenced this pull request Aug 6, 2024
@misch7 @minosgalanakis
Update the submodule to the head of PR in the framework repository
c695fc5 
See Mbed-TLS/mbedtls-framework#23

Signed-off-by: Michael Schuster <michael@schuster.ms>
@minosgalanakis minosgalanakis mentioned this pull request Aug 6, 2024
Merged
5 tasks
minosgalanakis pushed a commit to misch7/mbedtls that referenced this pull request Aug 9, 2024
@misch7 @minosgalanakis
Update the submodule to the head of PR in the framework repository
a52952d 
See Mbed-TLS/mbedtls-framework#23

Signed-off-by: Michael Schuster <michael@schuster.ms>
misch7 added 2 commits August 9, 2024 18:08
@misch7
Generate static test functions & wrappers to fix missing-prototype er…
17bedf7 
…rors in mbedtls/tests/suites

Required for: Mbed-TLS/mbedtls#9189

Signed-off-by: Michael Schuster <michael@schuster.ms>
@misch7
Update unit test for generate_test_code.py to take static test functi…
6a1dc7d 
…ons & wrappers into account

Signed-off-by: Michael Schuster <michael@schuster.ms>
minosgalanakis pushed a commit to minosgalanakis/mbedtls that referenced this pull request Aug 9, 2024
@misch7 @minosgalanakis
Update the submodule to the head of PR in the framework repository
40c1c36 
See Mbed-TLS/mbedtls-framework#23

Signed-off-by: Michael Schuster <michael@schuster.ms>
@minosgalanakis minosgalanakis mentioned this pull request Aug 9, 2024
Closed
5 tasks
misch7 added a commit to misch7/mbedtls that referenced this pull request Aug 9, 2024
@misch7
Update the submodule to the head of PR in the framework repository
b77c419 
See Mbed-TLS/mbedtls-framework#23

Signed-off-by: Michael Schuster <michael@schuster.ms>
gilles-peskine-arm pushed a commit to minosgalanakis/mbedtls that referenced this pull request Aug 10, 2024
@misch7 @gilles-peskine-arm
Update the submodule to the head of PR in the framework repository
3001e27 
See Mbed-TLS/mbedtls-framework#23

Signed-off-by: Michael Schuster <michael@schuster.ms>
Signed-off-by: Gilles Peskine <gilles.peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm merged commit 94599c0 into Mbed-TLS:main Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minosgalanakis minosgalanakis minosgalanakis approved these changes

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap Board for Mbed TLS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@misch7 @minosgalanakis @gilles-peskine-arm