Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test helpers to framework repo #37

Closed
wants to merge 81 commits into from
Closed

Add test helpers to framework repo #37

wants to merge 81 commits into from

Conversation

davidhorstmann-arm
Copy link
Contributor

Move the contents of tests/src and tests/include (excluding tests/include/alt-dummy) to the framework and adjust references to these paths accordingly.

minosgalanakis and others added 30 commits May 1, 2024 17:14
@minosgalanakis
Updated the PR template with new checkboxes
6e450c7 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis @yanesca
Update .github/pull_request_template.md
1deadf5 
Co-authored-by: Janos Follath <janos.follath@arm.com>
Signed-off-by: minosgalanakis <30719586+minosgalanakis@users.noreply.github.com>
@minosgalanakis
Update .github/pull_request_template.md
ad94717 
Removed discrete link referencing and updated text entries.

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@valeriosetti
psa: fix parameters' names of psa_key_derivation_verify_bytes()
fc37c10 
PSA buffers and their length should follow a pattern for which
the latter is named after the former as <buffer_name>_length,
but this was not the case for psa_key_derivation_verify_bytes().

This makes life of crypto.h parsers (for automatic code generation)
harder. This commit aims at solving this problem.

Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@tom-daubney-arm
Remove MBEDTLS_RSA_ALT
f47b66e 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Remove MBEDTLS_DHM_ALT
5edad7f 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Remove MBEDTLS_ECJPAKE_ALT
e647d8f 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Remove MBEDTLS_ECP_ALT and associated options
9da1769 
Also removed are all options of the form
MBEDTLS_ECP_XXX_ALT as well as
MBEDTLS_ECP_NO_FALLBACK.

Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Modify rsa_alt_helpers.h docs
3507d76 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@davidhorstmann-arm
Move some files to framework repository
b744dd3 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Update paths pointing to tests/data_files
dcf18dd 
These now point to framework/data_files instead.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Update directory-climbing path in context-info.sh
4481698 
A path containing '../../' was defined in relation to a directory in the
tests/data_files directory. Since this has been moved to
framework/data_files, we must update the path to refer correctly to the
same location as before.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Fix line-too-long in generate_tls13_compat_tests.py
eb8abda 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Correct redundant framework/../framework paths
441b66c 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Replace data_files path with variable in compat.sh
d178031 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Use variable for data_files path in ssl-opt.sh
184c4f0 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Simplify data_files path in compat test generation
661c088 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Simplify path in audit-validity-dates.py
f36b7bc 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Move variable into generated bash
b51ed61 
Move the DATA_FILES_PATH_VAR variable into the generated bash rather
than only variablising it in the python that generates the test script.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Update generated tls13 testcase script
0cbf8d5 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Update framework submodule
53ce048 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
@ronald-cron-arm
Merge pull request #9271 from tom-daubney-arm/remove_asymmetric_crypt…
1d25626 
…o_alt_interface

Remove asymmetric crypto alt interfaces
@minosgalanakis
Update .github/pull_request_template.md
797e43b 
* Removed strike-out marks and added | symbols for selection.
* Added framework tracking checkbox.

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@ronald-cron-arm
Update the framework submodule to the merge of PR18
0ce9fa9 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Merge pull request #9249 from davidhorstmann-arm/move-test-data-files…
fe3ad99 
…-to-framework

Move test data files to framework
@ronald-cron-arm
Move crypto modules
90ca414 
Move all the modules that constitute
the crypto library as well as the
associated headers to tf-psa-crypto/core
for the PSA core modules and to
tf-psa-crypto/drivers/builtin/src for
the others.

The common.h file is copied instead of
being just moved as eventually they
will be different in mbedtls and
TF-PSA-Crypto. Some parts of it can be
shared though but this will be done later,
probably when adding the CMake build
system in tf-psa-crypto.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Adjust build systems
c29afb6 
Adjust build systems such as we can built
Mbed TLS in the default and full configuration.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Adapt make cscope
52cd108 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Adapt libtestdriver1 build
b2bdb78 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
@ronald-cron-arm
Adapt check_names.py
6921d54 
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
gilles-peskine-arm and others added 22 commits July 12, 2024 12:11
@gilles-peskine-arm
Merge pull request #9211 from eleuzi01/replace-mbedtls-md-can-sha3-224
6a5278b 
Replace MBEDTLS_MD_CAN_SHA3_224 with PSA_WANT_ALG_SHA3_224
@bensze01
Merge pull request #9268 from tom-daubney-arm/remove_symmetric_crypto…
3f2d9b6 
…_alt_interface

Remove symmetric crypto alt interface
@eleuzi01
Replace MBEDTLS_MD_CAN_SHA3_384 with PSA_WANT_ALG_SHA3_384
db0421c 
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
@eleuzi01
Replace MBEDTLS_MD_CAN_SHA3_384 in md.h
7a507d2 
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
@tom-daubney-arm
Remove MBEDTLS_AES_ALT
4137609 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Remove MBEDTLS_CCM_ALT
b4914cf 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Remove MBEDTLS_GCM_ALT
c7cb810 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Remove MBEDTLS_CAMELLIA_ALT
e9fe311 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Remove MBEDTLS_ARIA_ALT
064f1df 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Remove MBEDTLS_DES_ALT
a9ea6f8 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Remove MBEDTLS_NIST_KW_ALT
25e2be1 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Remove MBEDTLS_TEST_HAVE_ALT_GCM
ebeef15 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Improved AES comment
478efd7 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Restore config option
356309f 
Restore previously removed option but with a more
relevant name.

Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@tom-daubney-arm
Update comment in further places
53377f1 
Signed-off-by: Thomas Daubney <thomas.daubney@arm.com>
@bensze01
Merge pull request #9213 from eleuzi01/replace-mbedtls-md-can-sha3-384
3f40127 
Replace MBEDTLS_MD_CAN_SHA3_384 with PSA_WANT_ALG_SHA3_384
@bensze01
Merge pull request #9259 from tom-daubney-arm/remove_aes-like_alt_int…
f974bff 
…erface

Remove AES-like alt interface
@gilles-peskine-arm
Merge pull request #9308 from valeriosetti/fix-psa_key_derivation_ver…
5f616e9 
…ify_bytes

psa: fix parameters' names of psa_key_derivation_verify_bytes()
@davidhorstmann-arm
Move some files to framework repository
eff4db6 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Merge branch 'tmp-branch-move-files-to-framework' into dev/davidhorst…
a3aae68 
…mann-arm/add-test-helpers
@davidhorstmann-arm
Update references to tests/src
9819b04 
Update paths in generating scripts that refer to tests/src. These will
now generate files instead in framework/tests/src (relative to the
main repo root directory).

Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Update comment references to test helpers
bde4a56 
Update references to tests/src and tests/include in a code comment now
that these live in the framework.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm davidhorstmann-arm added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon labels Jul 18, 2024
@davidhorstmann-arm davidhorstmann-arm mentioned this pull request Jul 18, 2024
Closed
5 tasks
@minosgalanakis minosgalanakis mentioned this pull request Jul 24, 2024
Merged
@davidhorstmann-arm
Copy link
Contributor Author

Superseded by #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@davidhorstmann-arm @minosgalanakis @valeriosetti @tom-daubney-arm @ronald-cron-arm @eleuzi01 @paul-elliott-arm @gilles-peskine-arm @bensze01