Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Curve448 via the PSA API #4249

Closed
gilles-peskine-arm opened this issue Mar 23, 2021 · 2 comments
Closed

Support Curve448 via the PSA API #4249

gilles-peskine-arm opened this issue Mar 23, 2021 · 2 comments
Labels
component-crypto Crypto primitives and low-level interfaces component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement help-wanted This issue is not being actively worked on, but PRs welcome.

Comments

@gilles-peskine-arm
Copy link
Contributor

gilles-peskine-arm commented Mar 23, 2021 •
edited
Loading

Importing a Curve448 key fails.

To reproduce, add this block to tests/suites/test_suite_psa_crypto.data:

PSA import/export-public EC curve448: good
depends_on:PSA_WANT_ALG_ECDH:PSA_WANT_KEY_TYPE_ECC_KEY_PAIR:MBEDTLS_PK_PARSE_C:MBEDTLS_PK_WRITE_C:PSA_WANT_ECC_MONTGOMERY_448
import_export_public_key:"9a8f4925d1519f5775cf46b04b5800d4ee9ee8bae8bc5565d498c28dd9c9baf574a9419744897391006382a6f127ab1d9ac2d8c0a598726b":PSA_KEY_TYPE_ECC_KEY_PAIR(PSA_ECC_FAMILY_MONTGOMERY):PSA_ALG_ECDH:0:PSA_SUCCESS:"9b08f7cc31b7e3e67d22d5aea121074a273bd2b83de09c63faa73d2c22c5d9bbc836647241d953d40c5b12da88120d53177f80e532c41fa0"

Definition of done for this issue:

  • Pass a known-answer public key export test.
  • Pass a known-answer ECDH (X448) test.
  • Curve448 dependencies in include/psa/crypto_config.h and include/mbedtls/config_psa.h are declared like other curves.
  • The Curve448 storage tests run and pass.
  • Pass unit tests for masking as described by RFC 7748.
@gilles-peskine-arm gilles-peskine-arm added enhancement help-wanted This issue is not being actively worked on, but PRs welcome. component-crypto Crypto primitives and low-level interfaces Product Backlog component-psa PSA keystore/dispatch layer (storage, drivers, …) labels Mar 23, 2021
gilles-peskine-arm added a commit to gilles-peskine-arm/mbedtls that referenced this issue Mar 23, 2021
@gilles-peskine-arm
Curve448 is not yet supported via the PSA API
8276986 
Filed as Mbed-TLS#4249. In the
meantime, disable the feature.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm mentioned this issue Mar 23, 2021
Merged
daverodgman pushed a commit that referenced this issue Apr 23, 2021
@gilles-peskine-arm
Curve448 is not yet supported via the PSA API
b0e51c3 
Filed as #4249. In the
meantime, disable the feature.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@silabs-ArchanaM silabs-ArchanaM mentioned this issue Jun 8, 2021
Merged
2 tasks
@daverodgman
Copy link
Contributor

@gilles-peskine-arm should we close? I think this was covered by #4626.

@gilles-peskine-arm
Copy link
Contributor Author

This was done in #4626.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component-crypto Crypto primitives and low-level interfaces component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement help-wanted This issue is not being actively worked on, but PRs welcome.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daverodgman @gilles-peskine-arm