PSA: don't run tests for unsupported curves #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filed as Mbed-TLS#4249. In the meantime, disable the feature. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Filed as Mbed-TLS#3541. In the meantime, disable the feature. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
bug
needs-review
If an elliptic curve was enabled in the Mbed TLS classic API (#define MBEDTLS_ECP_DP_xxx), but not enabled in the PSA configuration (#define PSA_WANT_ECC_xxx), it would still work if you tried to use it through PSA. This is generally benign, but could be a security issue if you want to disable a curve in PSA for some security reason (such as a known bug in its implementation, which may not matter in the classic API if Mbed TLS is running in a secure enclave and is only reachable from untrusted callers through the PSA API). More urgently, this broke test_suite_psa_crypto_not_supported.generated. So if a curve is not enabled in the PSA configuration, ensure that it's treated as unsupported through the PSA software implementation. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Filed as Mbed-TLS#3541. In the meantime, disable the ssl-opt.sh test case that uses it. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
ronald-cron-arm
removed
the
needs-reviewer
bensze01
added
approved
daverodgman
pushed a commit
that referenced
this pull request
Apr 23, 2021
PSA: don't run tests for unsupported curves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curve448 and secp224k1 currently don't work through the PSA crypto API. Don't enable them in the configuration.
Urgent because CI broke due to the combination of #4214 (adding systematically generated test cases for all curves including these, but the test cases didn't run because the dependency symbols weren't declared) and #4158 (adding the dependency symbols for all curves including these).