[Baremetal] Harmonize static function compiler flags #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanno-becker
added
branch: baremetal
bug
needs-ci
Warnings are treated as errors in Mbed TLS test. An error "ssl_parse_client_hello_v2’ defined but not used" can occur in some specific configurations and therefore tests will break. Use similar flags for static function "ssl_parse_client_hello_v2" as what is used when calling the function to prevent the compilation warning/error.
artokin
force-pushed
the
harmonize_static_function_flags
branch
from
c5368a3 to
d198672
Compare
|
Force pushed to get CI re-triggered. |
mpg
approved these changes
Oct 1, 2019
mpg
added
approved
simonbutcher
added
needs-ci
|
CI jobs have failed for no obvious reasonable reason. Just in case it's a spurious fault, I've restarted the job. Downgrading from 'ready to merge' to 'needs: CI'. |
|
Latest CI failures were only due to the known-flaky "DTLS reconnect" test in |
|
The only failure in the CI is the API-ABI check on pr-head (passing on pr-merge) which as discussed in the daily is an artefact of how the checker works and the fact that another PR merged in the meantime changed the ABI. Therefore, ignoring it and marking the PR as "ready for merge" anyway. |
mpg
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warnings are treated as errors in Mbed TLS test. An error
"ssl_parse_client_hello_v2’ defined but not used" can occur in some
specific configurations and therefore tests will break.
Use similar flags for static function "ssl_parse_client_hello_v2" as
what is used when calling the function to prevent the compilation
warning/error.
Status
READY