Replace reserved identifier clashes with suitable replacements #4750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutotakano
added
bug
needs-review
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
gilles-peskine-arm
requested changes
Jul 13, 2021
There was a problem hiding this comment.
Please rename _RR in bignum.h.
I think this warrants a changelog entry under Bugfix, since our code had undefined behavior. Something like
Don't use reserved identifiers as local variables. Fixes #4630.
Other than that, looks good to me.
The CI complaint is a warning that a renamed parameter could indicate a semantic change. Since we know the parameter didn't change semantics, this is a false positive.
gilles-peskine-arm
added
needs-work
and removed
needs-review
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
yutotakano
force-pushed
the
fix-reserved-identifier-clash
branch
from
71110d9 to
538a0cb
Compare
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
yutotakano
added
needs-review
This was referenced Jul 14, 2021
gilles-peskine-arm
approved these changes
Jul 16, 2021
gilles-peskine-arm
removed
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4630. C unconditionally reserves identifiers that either begin with two underscore, or a single underscore followed by a capital letter. MbedTLS has a few of these, and they could cause unwanted effects if the compilers decide to use these identifiers.
A slightly modified version of the grep in the issue was used to find all matches.
_Bwas replaced withBsince it was safe to do so._RR(representing the precomputed value of R squared) was replaced withprec_RRsinceRRis defined in the same scope. The header file (bignum.h) was also edited to reflect this change.Open to other names, since I'm not very proud of
prec_RRbut I can't think of anything better other than the explicit and longprecomputed_RR.Status
READY
Requires Backporting
Yes, because it is a bugfix.
Requires ChangeLog entry
Yes, as a bugfix.