Backport 2.x: Replace reserved identifier clashes with suitable replacements #4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
Signed-off-by: Yuto Takano <yuto.takano@arm.com>
yutotakano
added
bug
needs-review
2 tasks
gilles-peskine-arm
approved these changes
Jul 16, 2021
gilles-peskine-arm
added
single-reviewer
ronald-cron-arm
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #4750, and it fixes #4630 for the 2.x maintenance branch. Identical edits were made by cherry-picking the commits, and verifying with a grep that the pattern existed nowhere.
It is a bug fix (and has a corresponding entry in the ChangeLog) because reserved identifiers had undefined behavior that could depend on the compiler. We eliminate any uncertainty in its behavior by making variable names conform to the requirements set by C.