Fix test code to can be built on alpine

[jclab-joseph]

Signed-off-by: joseph joseph@jc-lab.net

Description

When build via cmake on alpine linux, cause the following error: This PR fix the error.

[ 99%] Building C object tests/CMakeFiles/test_suite_net.dir/test_suite_net.c.o
In file included from .../tests/suites/test_suite_net.function:12:
/usr/include/sys/fcntl.h:1:2: error: #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h> [-Werror=cpp]
    1 | #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h>
      |  ^~~~~~~
cc1: all warnings being treated as errors

Status

READY

Requires Backporting

NO

Migrations

If there is any API change, what's the incentive and logic for it.

NO

Steps to test or reproduce

Before

https://github.com/jclab-joseph/mbedtls/actions/runs/1264843158

The build succeeds in ubuntu but fails in alpine.

After

https://github.com/jclab-joseph/mbedtls/actions/runs/1264845085

Both ubuntu and alpine builds succeed.

[gilles-peskine-arm]

The obvious concern with this change is portability. library/net_sockets.c uses fcntl.h. So this reconciles the tests with the library. Besides sys/fcntl.h is long obsolete (for example FreeBSD switch to fcntl.h between 1.1 and 2.0, i.e. in the early 1990s). Hence, approved, thanks for fixing this.

Since this is a bug fix, even if it's only in the tests, I think this should have a changelog entry. Please create a file in ChangeLog.d (see the readme)) containing something like “Don't use the obsolete header path sys/fcntl.h in unit tests.”

Please make a similar patch to the long-time support branches: development_2.x and mbedtls-2.16.

[jclab-joseph]

Added Change.
In mbedtls-2.16 this test does not exist.

[daverodgman]

LGTM