Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.x: Fix test code to can be built on alpine #4969 #4970

Conversation

jclab-joseph
Copy link
Contributor

@jclab-joseph jclab-joseph commented Sep 23, 2021

Description

This is backporting for 2.x about #4969 pr.

When build via cmake on alpine linux, cause the following error: This PR fix the error.

[ 99%] Building C object tests/CMakeFiles/test_suite_net.dir/test_suite_net.c.o
In file included from .../tests/suites/test_suite_net.function:12:
/usr/include/sys/fcntl.h:1:2: error: #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h> [-Werror=cpp]
    1 | #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h>
      |  ^~~~~~~
cc1: all warnings being treated as errors

Status

READY

Requires Backporting

NO

Migrations

If there is any API change, what's the incentive and logic for it.

NO

Steps to test or reproduce

Before

https://github.com/jclab-joseph/mbedtls/actions/runs/1264843158

The build succeeds in ubuntu but fails in alpine.

After

https://github.com/jclab-joseph/mbedtls/actions/runs/1264845085

Both ubuntu and alpine builds succeed.

Signed-off-by: joseph <joseph@jc-lab.net>
@daverodgman daverodgman self-requested a review September 24, 2021 09:40
@daverodgman daverodgman added bug size-s Estimated task size: small (~2d) labels Sep 24, 2021
@daverodgman daverodgman added needs-review Every commit must be reviewed by at least two team members, single-reviewer This PR qualifies for having only one reviewer labels Sep 24, 2021
Copy link
Contributor

@daverodgman daverodgman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daverodgman daverodgman added needs-backports Backports are missing or are pending review and approval. and removed needs-review Every commit must be reviewed by at least two team members, labels Sep 24, 2021
@gilles-peskine-arm gilles-peskine-arm removed the needs-backports Backports are missing or are pending review and approval. label Sep 24, 2021
@gilles-peskine-arm gilles-peskine-arm merged commit 7358065 into Mbed-TLS:development_2.x Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants