Refactor Mc-Auth and introduce automated tests #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is going to be a tough journey... I plan to cover as much as possible with unit tests and use it to refactor and recode parts of Mc-Auth. This should make maintaining it easier and I can learn something new ^^
Should be extracted into its own package in the future
The main focus was on writing unit test with only small changes to the implementation so I can update all the dependencies and then continue refactoring while having tests to rely on. Everything relies on each other and relying on the index.ts for example starts the whole WebServer 'n stuff - That's why most things have been moved into classes
* Dev builds contain source maps while production builds don't. * The docker image builds the project itself to isolate external factors introduced by the host system * Some npm scripts now expect a `bash` shell (won't work on usual windows setup, but I don't care right now)
SpraxDev
force-pushed
the
the-big-cleanup
branch
from
8c12c8c to
19934a3
Compare
GitHub Actions: Don't use external dependency for SonarCloud GitHub Actions: Fixes SonarCloud not installing dependencies
SpraxDev
force-pushed
the
the-big-cleanup
branch
from
19934a3 to
c1ef466
Compare
If the config on the file system is missing something compared to the default config (or doesn't even exist), this will make sure that a new version is written to the file system
When mounting a volume to these directories, those had their permissions set to the user that is creating the container (e.g. root:root) instead of the node user of the container
SpraxDev
force-pushed
the
the-big-cleanup
branch
from
5e7ba23 to
50c5162
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
I'm not sure what values make any sense for rate-limiting. But better a limit that's too high then a limit that doesn't exist. Login and some other routes need rate limits too!
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be a tough journey...
I plan to cover as much as possible with unit tests and use it to refactor and recode parts of Mc-Auth.
This should make maintaining it easier and I can learn something new ^^
Planned
High test coverage(moved to Higher test coverage #198)Mutation tests (maybe Stryker Mutator?)(moved to Higher test coverage #198)Heavily refactored code(moved to Heavily refactor code #197)