Refactor Mc-Auth and introduce automated tests

.dockerignore

@@ -0,0 +1,9 @@
+*
+!dist/
+!resources/
+!src/
+!package.json
+!package-lock.json
+!tsconfig.json
+!LICENSE
+!README.md

.github/dependabot.yml

@@ -1,11 +1,14 @@
-# To get started with Dependabot version updates, you'll need to specify which
-# package ecosystems to update and where the package manifests are located.
 # Please see the documentation for all configuration options:
 # https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
 
 version: 2
 updates:
-  - package-ecosystem: "npm" # See documentation for possible values
-    directory: "/" # Location of package manifests
+  - package-ecosystem: "npm"
+    directory: "/"
     schedule:
       interval: "weekly"
+
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "monthly"

.github/workflows/codeql-analysis.yml

@@ -10,18 +10,22 @@ on:
     # The branches below must be a subset of the branches above
     branches: [ master ]
   schedule:
-    - cron: '24 21 * * 5'
+    - cron: '32 3 * * 6'
 
 jobs:
   analyze:
     name: Analyze
     runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
 
     strategy:
       fail-fast: false
       matrix:
-        language: [ 'javascript' ]
-        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
+        language: [ 'typescript' ]
+        # Learn more about CodeQL language support at https://git.io/codeql-language-support
 
     steps:
       - name: Checkout repository

.github/workflows/nodejs.yml

@@ -1,35 +1,29 @@
-# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
+# This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node
 # For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
 
-name: TypeScript Compile
+name: Node.js CI
 
 on:
   push:
     branches: [ master ]
   pull_request:
-    branches: [ master ]
+    types: [ opened, synchronize, reopened ]
 
 jobs:
   build:
     runs-on: ubuntu-latest
 
     strategy:
       matrix:
-        node-version: [ 12.x, 14.x ]  # Oldest 'Active' version: https://nodejs.org/en/about/releases/
+        node-version: [ 16.x, 17.x ]  # Oldest 'Active' version: https://nodejs.org/en/about/releases/
 
     steps:
       - uses: actions/checkout@v2
-      - name: Use Node.js v${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
-      - name: 'Cache: npm-node_modules'
-        uses: actions/cache@v1
-        with:
-          path: ./node_modules/
-          key: ${{ runner.os }}-npm-${{ hashFiles('./package-lock.json') }}
-      - run: npm i
+          cache: 'npm'
+      - run: npm ci
       - run: npm run build
-        #- run: npm test
-        env:
-          CI: true
+      - run: npm run test

.github/workflows/sonarcloud.yml

@@ -0,0 +1,31 @@
+name: Sonarcloud
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    types: [ opened, synchronize, reopened ]
+
+jobs:
+  SonarCloud:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v2
+        with:
+          node-version: 16.x
+          cache: 'npm'
+
+      - name: Run Tests
+        run: npm ci && npm run test
+
+      - name: SonarCloud Scan
+        uses: SonarSource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.gitignore

@@ -1,6 +1,13 @@
-/node_modules/
-/storage/
-/build/
+# Project
+/dist/
 /logs/
+/storage/
+
+
+# npm and other dependencies
+/node_modules/
+/coverage/
+
 
-/.idea/
+# JetBrains IDEs
+/.idea/

Dockerfile

@@ -0,0 +1,64 @@
+# syntax=docker/dockerfile:1
+FROM node:16-alpine as base
+
+LABEL maintainer="Christian Koop <contact@sprax2013.de>"
+
+RUN apk --no-cache -U upgrade && \
+    npm i -g npm --update-notifier false && \
+    npm cache clean --force
+
+RUN mkdir -p /app/storage/ /app/logs/ && \
+    chown -R node:node /app/
+WORKDIR /app/
+
+USER node
+
+COPY --chown=node:node LICENSE README.md ./
+COPY --chown=node:node package.json package-lock.json ./
+
+
+##
+# Builder: Compiles the project into js files (optionally generates source maps too)
+##
+FROM base as builder
+
+ARG BUILD_SCRIPT=build
+
+RUN npm ci
+COPY --chown=node:node tsconfig.json ./tsconfig.json
+COPY --chown=node:node src/ ./src/
+RUN npm run $BUILD_SCRIPT
+
+
+##
+# Development: Copies the resources, compiled js files and source maps and starts the application with source map support
+##
+FROM base as dev
+
+# TODO: Check if volume mounts could be beneficial for development
+RUN npm ci
+
+COPY --chown=node:node --from=builder /app/dist/ ./dist/
+COPY --chown=node:node resources/ ./resources/
+
+CMD ["node", "--enable-source-maps", "dist/index.js"]
+
+
+##
+# Production: Copies the resources and compiled js files and starts the application
+##
+FROM base as prod
+
+# TODO: This heavily relies on hostname being set and the default port 8080 being used
+HEALTHCHECK --interval=1m --timeout=30s --retries=3 \
+            CMD wget --spider $(hostname):8080
+
+ENV NODE_ENV=production
+RUN npm ci && \
+    npm cache clean --force && \
+    rm -Rf /home/node/.npm/
+
+COPY --chown=node:node --from=builder /app/dist/ ./dist/
+COPY --chown=node:node resources/ ./resources/
+
+CMD ["node", "dist/index.js"]