Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print queue interface improvements #1457

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

pavelbraginskiy
Copy link
Collaborator

After adding page breaks in a previous patch, I realized I found myself adding all my units first, then not being able to add page breaks where I want them.

Screenshot:
image

@pavelbraginskiy
Copy link
Collaborator Author

I'd like to replace the text of the buttons with nice up/down arrow icons, but I'm not sure how to accomplish such a thing.
I think it'd look nicer, if it was possible.

@Sleet01
Copy link
Collaborator

Sleet01 commented Mar 15, 2024

Could add a gridbag to the left of the unit list, with graphical buttons (using icons) instead of words or Unicode characters.
Then you wouldn't need to do any Localization testing.

There should be some code in MML you could purloin to read and set icons; then it's just a matter of creating a thin grid of 4 x 1 buttons next to the "Selected Units" element.

@pavelbraginskiy
Copy link
Collaborator Author

Added some icons I made myself.
New screenshot:
image

@pavelbraginskiy pavelbraginskiy marked this pull request as ready for review March 15, 2024 22:10
@Sleet01
Copy link
Collaborator

Sleet01 commented Mar 15, 2024

Added some icons I made myself

Those. Are. Awesome.

@HammerGS HammerGS merged commit d142c96 into MegaMek:master Mar 19, 2024
4 checks passed
@pavelbraginskiy pavelbraginskiy deleted the print_queue_improvements branch March 19, 2024 02:00
HammerGS added a commit that referenced this pull request Mar 19, 2024
+ PR #1457: Print queue interface improvements
+ PR #1462: When printing from MUL, calculate BV from C3/Tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants