Large engine crits #353
Merged
Large engine crits #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing between normal and large engine may change the number of engine crits.
neoancient
requested review from
sixlettervariables,
AaronGullickson and
NickAragua
| // Clan and large flags are specific to the engine. the superheavy flag depends on the mech | ||
| // and may have changed since the last refresh. | ||
| int flags = e.getFlags() & (Engine.CLAN_ENGINE | Engine.LARGE_ENGINE); | ||
| // Clan and flag is specific to the engine. the superheavy and large flags depend on the mech |
There was a problem hiding this comment.
"Clan and flag..." ?
sixlettervariables
approved these changes
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352
Large engines (rating > 400) occupy more critical slots and may need to punt equipment that has previously been installed there. The call to resetSystemCrits was missing in the method that recalculates engine rating. There was also a bug that assumed the large engine flag was set correctly in the engine combo box, but this was not always true. Also, superheavy mechs were reserving four slots for the gryo, when then should only be requiring two double slots.