Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact heat sink fixes #928

Merged
merged 2 commits into from
Jun 12, 2021
Merged

Compact heat sink fixes #928

merged 2 commits into from
Jun 12, 2021

Conversation

neoancient
Copy link
Member

  1. When switching to compact heat sinks on a mixed tech Clan mech, laser heat sinks are installed instead. This is a problem in UnitUtil#getHeatSinkType, which did not allow for mixed tech. I think the method needs to be removed, but the call chain goes several levels deep in other places and it's best left for another time. In this case the fix was simpler.
  2. The number of compact heat sinks showing on the build tab to be allocated is not reduced when the engine rating increases. This is because of a requirement that engine heat sinks are always one per mount, which means that the paired mounts need to be split. Decreasing the engine rating requires that some of those singles must be allocated, which means they get paired up. I couldn't find any sign that MML ever did that properly, though I may have rewritten some code at some point and broken it.

Fixes #890

@neoancient neoancient merged commit 0ecc868 into master Jun 12, 2021
@neoancient neoancient deleted the compact_hs branch June 12, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixed Tech QuaddVee Compact Heat Sinks multiple problems.
2 participants