Advanced flag #149
Advanced flag #149
Conversation
This is only for httprouter. Still need to add for other frameworks
GitHubAction Templates for generated projects
# Conflicts: # cmd/create.go # cmd/program/program.go # cmd/steps/steps.go
…into advanced-flag
|
This is PROD-ready, there is no need to merge into the staging branch. |
cmd/program/program.go
Outdated
| if err != nil { | ||
| log.Fatal(err) | ||
| } |
There was a problem hiding this comment.
if placehodler does not get re-written, is it going to log fatal?
There was a problem hiding this comment.
When running through it with the flag being false, it doesn't not log fatal. The Parse is just taking in a string so I think it'll be fine no matter what the string is, right?
| } | ||
| err = spinner.ReleaseTerminal() | ||
| if err != nil { | ||
| log.Printf("Could not release terminal: %v", err) |
There was a problem hiding this comment.
nit:
if we get here, cant we make sure to release the terminal for them? Maybe explicitly setting a kill for the terminal? Otherwise it will be hanging and the user needs to close the terminal.
Not blocking, just some food for thought
There was a problem hiding this comment.
What would that look like? Would we want to do an os.Exit or something like that?
Won't the CheckErr handle exiting with a non-zero exit code?
Sorry if these are simple questions.
# Conflicts: # cmd/program/program.go
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Problem/Feature
This introduces the
--advancedflag discussed in #147.Description of Changes:
As of right now when creating the draft PR, the HTMX/Templ support is incomplete. Below is a list of places it needs to be added. I wanted to get the draft PR open in case others wanted to start adding to it. I'll keep adding to it the rest of the week/weekend and hopefully we can get something ready to merge by next week.
routes
dbRoutes
Checklist