issue: HPCINFRA-1734 [CI] Coverity: upgrade to v2023.12 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasharRadya
force-pushed
the
coverity
branch
9 times, most recently
from
00f64f2
to
d27e83a
Compare
iftahl
reviewed
Jul 8, 2024
|
bot:retest |
BasharRadya
force-pushed
the
coverity
branch
5 times, most recently
from
48c35cc
to
b8cd008
Compare
|
bot:retest |
|
bot:retest |
|
replace "HPCINFRA-1734" in commit messages to XLIO's ticket number |
iftahl
approved these changes
Jul 10, 2024
Upgrade coverity to version 2023.12 Signed-off-by: Bashar Abdelgafer <babdelgafer@nvidia.com>
Removed redundant if check after ensuring buffer stack initialization Suppressed Coverity null dereference warning (False Positive) Initialized uninitialized class members stats_file and m_ioctl in mce_sys_var constructor Checked return value of gettime() in timer constructor and added error logging Signed-off-by: Bashar Abdelgafer <babdelgafer@nvidia.com>
- Use move constructors and assignment operators for m_source, ring_allocation_logic, m_ip_addrs, and source_t to replace copy constructors and assignment - Simplify event_data_t initialization with concise constructor calls in event_handler_manager.cpp, causing assigned objects to be temporary rvalue references which invoke move semantics - Add specialized constructors for EV_IBVERBS, EV_RDMA_CM and EV_COMMAND types in event_data_t - Remove use of std::forward in ip_address constructor because addr is used afterward and would be in an unknown state if moved Signed-off-by: Bashar Abdelgafer <babdelgafer@nvidia.com>
Guard m_error_queue in handle_recv_errqueue with lock when checking if it's empty since it's a shared resource. handle_recv_errqueue is only called in a few cases when the flag MSG_ERRQUEUE is set, so this change will cause no degradation Change iftype_value from char to int in get_iftype_from_ifname since iftype_value, which is returned from the function, is derived from atoi, which returns an int Change proto variable 16-bit positive number type from short to uint16_t, and update all occurrences in all functions Signed-off-by: Bashar Abdelgafer <babdelgafer@nvidia.com>
Suppress irrelevant and false positive Coveritywarnings in various files using comments Turn off Coverity checks for sum of null dereference overflow, missing lock, assigned pointer, copy assignment call and other identified issues Signed-off-by: Bashar Abdelgafer <babdelgafer@nvidia.com>
|
@BasharRadya , please move to fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're requested to upgrade the Coverity version to 2023.12
What
The PR runs Coverity v2023.12 against the Xlio codebase
Why ?
Justification for the PR. If there is existing issue/bug please reference.
How ?
It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.
Change type
What kind of change does this PR introduce?
Check list