Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue: HPCINFRA-1734 [CI] Coverity: upgrade to v2023.12 #176

Merged
merged 5 commits into from
Jul 10, 2024
Merged

issue: HPCINFRA-1734 [CI] Coverity: upgrade to v2023.12 #176

merged 5 commits into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. issue: 3848340 HPCINFRA-1734 Coverity: upgrade to v2023.12 

    Upgrade coverity to version 2023.12

Signed-off-by: Bashar Abdelgafer  <babdelgafer@nvidia.com>
    @BasharRadya
    BasharRadya committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f139239 View commit details
    Browse the repository at this point in the history

  2. issue: 3848340 Coverity fix uninitialized & unchecked return value 

    Removed redundant if check after ensuring buffer stack initialization
Suppressed Coverity null dereference warning (False Positive)

Initialized uninitialized class members stats_file and m_ioctl
in mce_sys_var constructor

Checked return value of gettime() in timer constructor
and added error logging

Signed-off-by: Bashar Abdelgafer  <babdelgafer@nvidia.com>
    @BasharRadya
    BasharRadya committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    79387a6 View commit details
    Browse the repository at this point in the history

  3. issue: 3848340 Coverity Move Semantics 

    - Use move constructors and assignment operators for m_source,
ring_allocation_logic, m_ip_addrs, and source_t to replace copy
constructors and assignment
- Simplify event_data_t initialization with concise constructor
calls in event_handler_manager.cpp, causing assigned objects to
be temporary rvalue references which invoke move semantics
- Add specialized constructors for EV_IBVERBS, EV_RDMA_CM
and EV_COMMAND types in event_data_t
- Remove use of std::forward in ip_address constructor because
addr is used afterward and would be in an unknown state if moved

Signed-off-by: Bashar Abdelgafer  <babdelgafer@nvidia.com>
    @BasharRadya
    BasharRadya authored and root committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    d2e5dc1 View commit details
    Browse the repository at this point in the history

  4. issue: 3848340 Coverity Adjust Lock & Fix overflow 

    Guard m_error_queue in handle_recv_errqueue with lock when checking
if it's empty since it's a shared resource. handle_recv_errqueue is
only called in a few cases when the flag MSG_ERRQUEUE is set,
so this change will cause no degradation

Change iftype_value from char to int in get_iftype_from_ifname
since iftype_value, which is returned from the function, is
derived from atoi, which returns an int

Change proto variable 16-bit positive number type from short
to uint16_t, and update all occurrences in all functions

Signed-off-by: Bashar Abdelgafer  <babdelgafer@nvidia.com>
    @BasharRadya
    BasharRadya committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    cfe47de View commit details
    Browse the repository at this point in the history

  5. issue: 3848340 Coverity Supress FalsePositives 

    Suppress irrelevant and false positive Coveritywarnings
in various files using comments
Turn off Coverity checks for sum of null dereference
overflow, missing lock, assigned pointer, copy assignment call
and other identified issues

Signed-off-by: Bashar Abdelgafer  <babdelgafer@nvidia.com>
    @BasharRadya
    BasharRadya committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    fc82582 View commit details
    Browse the repository at this point in the history