Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NodeFeatureApi in NFD #567

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Enable NodeFeatureApi in NFD #567

merged 1 commit into from
Jul 11, 2023

Conversation

wmousa
Copy link
Contributor

@wmousa wmousa commented Jul 9, 2023

…namespace

This patch does the following:

  • Set enableNodeFeatureApi to true by default
  • Run the NFD with default annotation namespace
  • Enhance READE NFD documentation

Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please. re-format this commit message to:

Enable NodeFeatureApi in NFD

This patch does the following:
 - Set enableNodeFeatureApi to true by default
 - Run the NFD with default annotation namespace
 - Enhance README NFD documentation

Signed-off-by: Waleed Mousa <waleedm@nvidia.com>

This patch does the following:
 - Set enableNodeFeatureApi to true by default
 - Run the NFD with default annotation namespace
 - Enhance README NFD documentation

Signed-off-by: Waleed Mousa <waleedm@nvidia.com>
@wmousa wmousa changed the title Enable NodeFeatureApi in NFD and run the NFD with default annotation … Enable NodeFeatureApi in NFD Jul 10, 2023
Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It could be merged once CI passes

@wmousa
Copy link
Contributor Author

wmousa commented Jul 10, 2023

@adrianchiris
The following was tested:

  • Upgrading from the old version of NFD to the new version.
  • Deploy the GPU Operator with nfd.enabled=true, then deploy the Network operator with nfd.enabled=false
  • Deploy the GPU Operator with nfd.enabled=true, then deploy the Network operator with nfd.enabled=true
  • Deploy the Network operator with nfd.enabled=true, then deploy the GPU Operator with nfd.enabled=false
  • Deploy the Network operator with nfd.enabled=true, then deploy the GPU Operator with nfd.enabled=true
  • Dploy NFD using upstream charts, then, deploy the GPU Operator with nfd.enabled=false, then deploy the Network operator with nfd.enabled=false

@e0ne e0ne merged commit 734fdd4 into Mellanox:master Jul 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants