Skip to content

Commit

Permalink
fix(gas-fee-controller): add missing @metamask/polling-controller (#1748
Browse files Browse the repository at this point in the history
)

## Explanation

Adds missing dependency introduced in #1673

## References

- Follow-up to: #1673 

## Changelog


## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate

---------

Co-authored-by: Alex <adonesky@gmail.com>
  • Loading branch information
legobeat and adonesky1 authored Oct 2, 2023
1 parent 23b16dd commit 94175cd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
5 changes: 3 additions & 2 deletions constraints.pro
Original file line number Diff line number Diff line change
Expand Up @@ -298,14 +298,15 @@ gen_enforced_dependency(WorkspaceCwd, DependencyIdent, null, DependencyType) :-
workspace_has_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, DependencyType),
DependencyType == 'devDependencies'.

% If a controller dependency (other than `base-controller` and
% `eth-keyring-controller`) is listed under "dependencies", it should also be
% If a controller dependency (other than `base-controller`, `eth-keyring-controller` and
% `polling-controller`) is listed under "dependencies", it should also be
% listed under "peerDependencies". Each controller is a singleton, so we need
% to ensure the versions used match expectations.
gen_enforced_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, 'peerDependencies') :-
workspace_has_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, 'dependencies'),
DependencyIdent \= '@metamask/base-controller',
DependencyIdent \= '@metamask/eth-keyring-controller',
DependencyIdent \= '@metamask/polling-controller',
is_controller(DependencyIdent).

% All packages must specify a minimum Node version of 16.
Expand Down
1 change: 1 addition & 0 deletions packages/gas-fee-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"@metamask/controller-utils": "^5.0.1",
"@metamask/eth-query": "^3.0.1",
"@metamask/network-controller": "^13.0.1",
"@metamask/polling-controller": "^0.0.0",
"@metamask/utils": "^8.1.0",
"@types/uuid": "^8.3.0",
"ethereumjs-util": "^7.0.10",
Expand Down
3 changes: 2 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1807,6 +1807,7 @@ __metadata:
"@metamask/controller-utils": ^5.0.1
"@metamask/eth-query": ^3.0.1
"@metamask/network-controller": ^13.0.1
"@metamask/polling-controller": ^0.0.0
"@metamask/utils": ^8.1.0
"@types/jest": ^27.4.1
"@types/jest-when": ^2.7.3
Expand Down Expand Up @@ -2120,7 +2121,7 @@ __metadata:
languageName: unknown
linkType: soft

"@metamask/polling-controller@workspace:packages/polling-controller":
"@metamask/polling-controller@^0.0.0, @metamask/polling-controller@workspace:packages/polling-controller":
version: 0.0.0-use.local
resolution: "@metamask/polling-controller@workspace:packages/polling-controller"
dependencies:
Expand Down

0 comments on commit 94175cd

Please sign in to comment.