fix(gas-fee-controller): add missing @metamask/polling-controller #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
deps-gas-controller-add-polling-controller
branch
from
efd31f3
to
65d0632
Compare
legobeat
added
bug
legobeat
changed the title
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
legobeat
force-pushed
the
deps-gas-controller-add-polling-controller
branch
from
65d0632
to
128ed9c
Compare
Merged
legobeat
force-pushed
the
deps-gas-controller-add-polling-controller
branch
2 times, most recently
from
f6875b4
to
2ea2909
Compare
legobeat
force-pushed
the
deps-gas-controller-add-polling-controller
branch
from
2ea2909
to
46d975f
Compare
OGPoyraz
previously approved these changes
Oct 2, 2023
Gudahtt
reviewed
Oct 2, 2023
| @@ -55,7 +56,8 @@ | |||
| "typescript": "~4.8.4" | |||
| }, | |||
| "peerDependencies": { | |||
| "@metamask/network-controller": "^13.0.1" | |||
| "@metamask/network-controller": "^13.0.1", | |||
| "@metamask/polling-controller": "^0.0.0" | |||
There was a problem hiding this comment.
Welp. This shouldn't be a peerDependency in this case, but the contraints are enforcing it due to the name.
The intention was to enforce that controllers are peerDependencies of each other. But the polling-controller package is not itself a controller, it's a mixin meant to be used by controllers.
There was a problem hiding this comment.
Not sure how to proceed here @Gudahtt ?
There was a problem hiding this comment.
We can add an exception for polling-controller to the constraints here:
Line 308 in a1e1883
We've already added an exception for two other packages
There was a problem hiding this comment.
Ok I'll add that in this PR.
adonesky1
force-pushed
the
deps-gas-controller-add-polling-controller
branch
from
f68de2e
to
506ef4b
Compare
adonesky1
force-pushed
the
deps-gas-controller-add-polling-controller
branch
from
506ef4b
to
fb4260a
Compare
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
) ## Explanation Adds missing dependency introduced in #1673 ## References - Follow-up to: #1673 ## Changelog ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Alex <adonesky@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
) ## Explanation Adds missing dependency introduced in #1673 ## References - Follow-up to: #1673 ## Changelog ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Alex <adonesky@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 12, 2023
) ## Explanation Adds missing dependency introduced in #1673 ## References - Follow-up to: #1673 ## Changelog ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Alex <adonesky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adds missing dependency introduced in #1673
References
Changelog
Checklist