-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate libraries into core monorepo #1079
Comments
I propose we focus on the following libraries for Q3:
|
I went through the list of existing repos and found some that were omitted from the list above:
|
UPDATE October 17, 2023: Before starting work on future library migrations, please make sure to consult @MajorLift's migration checklist here. The instructions here only cover step B.0 in this checklist. One thing we want to absolutely make sure to do when we migrate a library to this repo is to preserve all of the Git history. I experimented with this using
Now we see why we performed step 2: because we want the library to initially be located in Here is a list of detailed steps:
The resulting pull request should look like this: #1520 |
## Explanation This is the first of two PRs that will migrate [`eth-json-rpc-provider`](https://github.com/MetaMask/eth-json-rpc-provider) into the core monorepo by following these steps: #1079 (comment). - This PR focuses on migrating the git history of the original package. - `eth-json-rpc-provider` is moved into a temporary directory in core (`merged-packages/`) with git history fully intact. - The second PR will remove the `merged-packages/` directory and integrate `eth-json-rpc-provider` into the `packages/` directory, resolving any issues arising from applying core monorepo linter/compiler/build settings to the newly added package. ## Blocked by - [x] MetaMask/eth-json-rpc-provider#29 ## References - Partially implements #1551 - See MetaMask/eth-json-rpc-provider#28 for preparatory steps taken in original repo. ## Changelog N/A since `@metamask/eth-json-rpc-provider` isn't usable from the monorepo as of this PR. ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Alex Donesky <alex.donesky@consensys.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> Co-authored-by: legobt <6wbvkn0j@anonaddy.me> Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
…on-rpc-provider" (#1790) ## Explanation - The contents of `merged-packages/` shouldn't be altered, as it's a temporary directory used for migrating packages into the monorepo. - Any dependency updates for the migration target package need to be handled manually. The migration process involves aligning dependency versions with the monorepo (which may not use the latest version), removing dependencies that are defined in the monorepo root, and removing the `yarn.lock` file from the migration target subpackage. ## Reference - Blocks #1764 - See #1079 (comment) for context on the role of `merged-packages/`.
…on-rpc-provider" (#1790) ## Explanation - The contents of `merged-packages/` shouldn't be altered, as it's a temporary directory used for migrating packages into the monorepo. - Any dependency updates for the migration target package need to be handled manually. The migration process involves aligning dependency versions with the monorepo (which may not use the latest version), removing dependencies that are defined in the monorepo root, and removing the `yarn.lock` file from the migration target subpackage. ## Reference - Blocks #1764 - See #1079 (comment) for context on the role of `merged-packages/`.
…on-rpc-provider" (#1790) ## Explanation - The contents of `merged-packages/` shouldn't be altered, as it's a temporary directory used for migrating packages into the monorepo. - Any dependency updates for the migration target package need to be handled manually. The migration process involves aligning dependency versions with the monorepo (which may not use the latest version), removing dependencies that are defined in the monorepo root, and removing the `yarn.lock` file from the migration target subpackage. ## Reference - Blocks #1764 - See #1079 (comment) for context on the role of `merged-packages/`.
browser-passworder, post-message-stream, web3-stream-provider — Not included because it's extension only |
We would like to migrate most MetaMask libraries into this monorepo to make them easier to maintain. We may want to exclude libraries that are:
Here is the list of libraries that seem like a good fit today:
https://github.com/MetaMask/scure-bip39This is a fork, so we might not want to do thisSee #1079 (comment) for instructions on accomplishing this.
The text was updated successfully, but these errors were encountered: