-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate eth-json-rpc-provider into core monorepo (1/2) #1755
Conversation
The package manifest, README, and PR template have been updated.
* Migrate both provider functions The functions `providerFromEngine` and `providerFromMiddleware` have been migrated from `@metamask/eth-json-rpc-middleware`. The `SafeEventEmitterProvider` is now a class with its own separate module, rather than a type. Hopefully this will help prevent future type errors. The error in the `SafeEventEmitterProvider` type in `@metamask/eth-json-rpc-middleware` has been corrected; the response in in the callback is now optional. Everything should be fully documented and tested. * Export type * Fix spelling mistake Co-authored-by: Alex Donesky <alex.donesky@consensys.net> * Improve test names --------- Co-authored-by: Alex Donesky <alex.donesky@consensys.net>
Bumps [@metamask/eslint-config-jest](https://github.com/MetaMask/eslint-config) from 11.0.0 to 11.1.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](MetaMask/eslint-config@v11.0.0...v11.1.0) --- updated-dependencies: - dependency-name: "@metamask/eslint-config-jest" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@metamask/eslint-config](https://github.com/MetaMask/eslint-config) from 11.0.2 to 11.1.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](MetaMask/eslint-config@v11.0.2...v11.1.0) --- updated-dependencies: - dependency-name: "@metamask/eslint-config" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Bumps [@metamask/eslint-config-typescript](https://github.com/MetaMask/eslint-config) from 11.0.2 to 11.1.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](MetaMask/eslint-config@v11.0.2...v11.1.0) --- updated-dependencies: - dependency-name: "@metamask/eslint-config-typescript" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Bumps [@metamask/eslint-config-nodejs](https://github.com/MetaMask/eslint-config) from 11.0.1 to 11.1.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](MetaMask/eslint-config@v11.0.1...v11.1.0) --- updated-dependencies: - dependency-name: "@metamask/eslint-config-nodejs" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
The version has been changed to v0.0.1 so that the first release can be v1. I set this to v1 forgetting that our release automation would also attempt to set this.
* deps: @metamask/safe-event-emitter@^2.0.0->^3.0.0 * deps: migrate from json-rpc-engine to @metamask/json-rpc-engine
v1.0.1 contains two changes that should have been considered semver-major: - Type-interface incompatability with previous version (MetaMask/json-rpc-engine#139) - Introduced dependency `@metamask/json-rpc-engine` indicates a minimum supported Node.js version of 16. This prevents the module from installing on some package manager configurations, like default yarn classic. This will be re-released as v2.0.0.
Required by update of `@metamask/json-rpc-engine` (#16)
Required by update of `@metamask/json-rpc-engine` (#16)
…25) * deps: @metamask/utils@^5.0.1->^8.1.0 * deps: @metamask/json-rpc-engine@^7.0.0->^7.1.0 * deps: @metamask/utils@^7.1.0->^8.1.0
- match compiler options with core monorepo - passes all tests Closes #1682
…norepo - added: `eslint-plugin-promise` - removed: `eslint-plugin-node` See: #1683
- added `eslint-import-resolver-typescript` v2.5.0 as dependency See: #1683
…e monorepo - See #1718 - See MetaMask/eth-json-rpc-provider#27 - Closes #1682
…-monorepo-deps-linter-configs' into 230927-migrate-eth-json-rpc-provider
…of migration (#28) ## Description - This PR aligns the ESLint and Prettier packages and configs in this repo with the core monorepo. - This is a preparation step for migrating the `eth-json-rpc-provider` package into the core monorepo. - Originally, the plan was to decrement the TypeScript version to align with the core monorepo, but following [this discussion](MetaMask/eth-json-rpc-provider#27), we've opted to use TypeScript version v4.8.4, and preserve the compiler options in this package that aren't enabled in the core monorepo. ## References - See #1551 - Closes #1683 - Closes #1682 (is superseded by this PR)
Add ISC license
…-migrate-eth-json-rpc-provider
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore-all All packages are current with main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ovider Migrate eth-json-rpc-provider into core monorepo (1/2)
Explanation
This is the first of two PRs that will migrate
eth-json-rpc-provider
into the core monorepo by following these steps: #1079 (comment).eth-json-rpc-provider
is moved into a temporary directory in core (merged-packages/
) with git history fully intact.merged-packages/
directory and integrateeth-json-rpc-provider
into thepackages/
directory, resolving any issues arising from applying core monorepo linter/compiler/build settings to the newly added package.Blocked by
References
eth-json-rpc-provider
into core monorepo #1551Changelog
N/A since
@metamask/eth-json-rpc-provider
isn't usable from the monorepo as of this PR.Checklist