fix: add tokenURI to compare nft data #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
sahar-fehri
force-pushed
the
fix/add-tokenUri-to-compareNftMetadata
branch
from
0a2a202
to
94c8811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
While i was testing NFT refreshing mechanism on Mobile with an Opensea collection, noticed that the tokenURI returned was the old URI, that was because the compareNftMetadata fct was returning false while it should have returned true.
I added the TokenURI as a key to compare with.
References
Changelog
@metamask/assets-controllersChecklist