Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 129.0.0 #4082

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Release 129.0.0 #4082

merged 6 commits into from
Mar 19, 2024

Conversation

sahar-fehri
Copy link
Contributor

This is the release candidate for 129.0.0. It adds an export for const SUPPORTED_CHAIN_IDS.
#4079

@MajorLift
Copy link
Contributor

MajorLift commented Mar 19, 2024

Could this release maybe wait to include some or all of the following PRs you currently have open?

@sahar-fehri
Copy link
Contributor Author

Could this release maybe wait to include some or all of the following PRs you currently have open?

Hey @MajorLift !
I inititially thought that it would be a quick and easy release, i have one bug fix PR on extension that i wanted to get in.
It can definitely wait for the rest if you think it is better.
Just want to mention:

@MajorLift
Copy link
Contributor

If this is urgent, we can definitely go ahead without waiting. Batching updates together is preferable, but keeping this PR open for too long and blocking other releases is also a concern.

I'll leave it up to you to merge this or wait to include #4030 based on your timeline.

MajorLift
MajorLift previously approved these changes Mar 19, 2024
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with releasing the changes outlined here for now and releasing more later, but I did have a comment about one of the changes.

packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Show resolved Hide resolved
@sahar-fehri sahar-fehri requested a review from mcmire March 19, 2024 16:38
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sahar-fehri sahar-fehri merged commit b89ffd3 into main Mar 19, 2024
139 checks passed
@sahar-fehri sahar-fehri deleted the release/129.0.0 branch March 19, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants