You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
## **Description**
Several e2e testcases about phishing detection are flaky.
## **Why they are flaky?**
After investigation, i think because when we open a malicious website,
selenium fetch very quickly all the DOM elements and consider they are
complete. When the page redirects to phishing detection page, it dose
not re-fetch elements so selenium cannot find buttons to click.
## **How i resolve it?**
I explicitly force selenium to switch to the phishing detection page
each time after redirection so it will re-fetch all elements on this
page.
## **Why do i think the fix works**
For each testcase, I ran locally 20 times and they all passed.
Fixes#21150
## **Description**
Several e2e testcases about phishing detection are flaky.
## **Why they are flaky?**
After investigation, i think because when we open a malicious website,
selenium fetch very quickly all the DOM elements and consider they are
complete. When the page redirects to phishing detection page, it dose
not re-fetch elements so selenium cannot find buttons to click.
## **How i resolve it?**
I explicitly force selenium to switch to the phishing detection page
each time after redirection so it will re-fetch all elements on this
page.
## **Why do i think the fix works**
For each testcase, I ran locally 20 times and they all passed.
Fixes#21150
What is this about?
Several e2e testcases about phishing detection are flaky that need to stabilize.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
References
No response
The text was updated successfully, but these errors were encountered: