Stabilize e2e tests for phishing detection

[chloeYue]

Description

Several e2e testcases about phishing detection are flaky.

Why they are flaky?

After investigation, i think because when we open a malicious website, selenium fetch very quickly all the DOM elements and consider they are complete. When the page redirects to phishing detection page, it dose not re-fetch elements so selenium cannot find buttons to click.

How i resolve it?

I explicitly force selenium to switch to the phishing detection page each time after redirection so it will re-fetch all elements on this page.

Why do i think the fix works

For each testcase, I ran locally 20 times and they all passed.

Fixes #21150

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0482ab6) 68.57% compared to head (cdb5a82) 68.57%.
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21152   +/-   ##
========================================
  Coverage    68.57%   68.57%           
========================================
  Files         1013     1013           
  Lines        40615    40615           
  Branches     10854    10854           
========================================
  Hits         27848    27848           
  Misses       12767    12767           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [cdb5a82]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (866 ± 399 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	178	126	27	13
		domContentLoaded	75	165	110	25	12
		load	87	2252	866	832	399
		domInteractive	75	165	110	25	12

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)