Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Settings - Basic Functionality does not appear on Settings search #25441

Closed
seaona opened this issue Jun 20, 2024 · 0 comments · Fixed by #25185
Closed

[Bug]: Settings - Basic Functionality does not appear on Settings search #25441

seaona opened this issue Jun 20, 2024 · 0 comments · Fixed by #25185
Labels
regression-prod-11.16.11 release-11.16.11 Issue or pull request that will be included in release 11.16.11 release-12.5.0 Issue or pull request that will be included in release 12.5.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Jun 20, 2024

Describe the bug

Basic Functionality does not appear on Settings search

Expected behavior

No response

Screenshots/Recordings

Screenshot from 2024-06-20 15-59-07

Steps to reproduce

  1. Go to settings
  2. Look for basic functionality
  3. See there are no results

Error messages or log output

No response

Version

11.16.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

@seaona seaona added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. release-11.16.11 Issue or pull request that will be included in release 11.16.11 labels Jun 20, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jun 20, 2024
@metamaskbot metamaskbot added the regression-prod-11.16.0 Regression bug that was found in production in release 11.16.0 label Jun 20, 2024
@seaona seaona added regression-prod-11.16.11 and removed regression-prod-11.16.0 Regression bug that was found in production in release 11.16.0 labels Jun 20, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jun 24, 2024
darkwing added a commit that referenced this issue Sep 5, 2024
## **Description**

Adds "Basic Functionality" to the Settings search

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25185?quickstart=1)

## **Related issues**

Fixes: #25441

## **Manual testing steps**

1. Go to Settings
2. Search the term "Basic"
3. See "Basic Functionality" and click it
4. End up on top of the Privacy tab

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Sep 5, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Sep 5, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 5, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-11.16.11 release-11.16.11 Issue or pull request that will be included in release 11.16.11 release-12.5.0 Issue or pull request that will be included in release 12.5.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-wallet-ux type-bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants