Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: user is unable to approve tokens for trading on decentralised exchange #27188

Closed
jpuri opened this issue Sep 17, 2024 · 1 comment · Fixed by #27203
Closed

[Bug]: user is unable to approve tokens for trading on decentralised exchange #27188

jpuri opened this issue Sep 17, 2024 · 1 comment · Fixed by #27203
Assignees
@jpuri
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. regression-prod-12.2 Regression bug that was found in production in release 12.2 release-12.5.0 Issue or pull request that will be included in release 12.5.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 type-bug

Comments

@jpuri
Copy link
Contributor

jpuri commented Sep 17, 2024 •
edited
Loading

Details:
MetaMask Version: 12.2.3
Browser and Version: Chrome 128.0.6613.138

Issue Description: The user is unable to approve tokens for trading on decentralised exchange (DEX) apps such as 1inch, Paraswap, Aave, and Venus across any chains, including Ethereum (ETH) and Binance Smart Chain (BSC). The approval button is not clickable.

Reproduction Steps:

  1. Open any of the mentioned DEX apps.
  2. Attempt to approve tokens for trading.
  3. Observe that the approval button is not clickable.

The user has confirmed that this issue is consistently reproducible.

The user confirmed that he can perform transactions using the previous extension version.

video_2024-09-15_23-57-57.mp4
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Sep 17, 2024
@jpuri jpuri self-assigned this Sep 17, 2024
@jpuri jpuri added the type-bug label Sep 17, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Sep 17, 2024
@jpuri jpuri added the regression-prod-12.2 Regression bug that was found in production in release 12.2 label Sep 17, 2024
@jpuri jpuri mentioned this issue Sep 17, 2024
Merged
7 tasks
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 17, 2024
@jpuri jpuri mentioned this issue Sep 17, 2024
Merged
7 tasks
danjm pushed a commit that referenced this issue Sep 17, 2024
@jpuri
fix(cherry-pick) : selector getKnownMethodData should return empty ob…
a09d076 
…ject if user has opted out for using 4Byte Resolution (#27213)

## **Description**
If user has toggled off **Decode smart contracts** setting he is not
able to approve ERC20. This is regression introduced recently.

## **Related issues**

Fixes: #27188

## **Manual testing steps**

1. Toggle off setting "Decode smart contracts"
2. Try to approve an ERC 20 
3. It should not throw error

## **Screenshots/Recordings**


https://github.com/user-attachments/assets/7f0fd8f9-3d97-4f4b-8e99-c694445ad929


## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Sep 19, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Sep 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on issue. Adding release label release-12.5.0 on issue, as issue is linked to PR #27203 which has this release label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. regression-prod-12.2 Regression bug that was found in production in release 12.2 release-12.5.0 Issue or pull request that will be included in release 12.5.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
2 participants
@jpuri @metamaskbot