Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cherry-pick) : selector getKnownMethodData should return empty object if user has opted out for using 4Byte Resolution #27213

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 17, 2024

Description

If user has toggled off Decode smart contracts setting he is not able to approve ERC20. This is regression introduced recently.

Related issues

Fixes: #27188

Manual testing steps

  1. Toggle off setting "Decode smart contracts"
  2. Try to approve an ERC 20
  3. It should not throw error

Screenshots/Recordings

Screen.Recording.2024-09-17.at.2.20.17.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations Push issues to confirmations team regression-prod-12.2.2 Regression bug that was found in production in release 12.2.2 labels Sep 17, 2024
@jpuri jpuri requested review from a team as code owners September 17, 2024 12:45
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm merged commit a09d076 into Version-v12.2.4 Sep 17, 2024
32 of 48 checks passed
@danjm danjm deleted the approve_4byte_resolution_fix branch September 17, 2024 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression-prod-12.2.2 Regression bug that was found in production in release 12.2.2 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants