[Bug]: When an account hasn't been enabled in the Permissions, attempting to initiate a transaction from a dApp results in the transaction being created from an enabled account but with the nonce value matching the account selected by user #28014
Assignees
Labels
release-12.8.0
Issue or pull request that will be included in release 12.8.0
Sev1-high
High severity; partial loss of service with severe impact upon users, with no workaround.
team-confirmations
Push issues to confirmations team
type-bug
Comments
sleepytanya
added
type-bug
regression-develop
sleepytanya
added
the
regression-RC-12.6.0
bschorchit
added
release-blocker
|
@jpuri reported this is not a v12.6 regression so I have updated the label. We'll continue to prioritize a fix for this issue |
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 6, 2024
## **Description** Use transaction from address to get custom nonce value. ## **Related issues** Fixes: #28014 ## **Manual testing steps** 1. Enable an account connected to the dApp 2. Switch to non-enabled account in the MetaMask 3. Initiate a transaction from the dApp 4. Ensure correct nonce is displayed ## **Screenshots/Recordings** TODO ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-12.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When an account hasn't been enabled in the
Permissions, attempting to initiate a transaction from a dApp results in the transaction being created from a different, enabled account. Interestingly, the nonce value corresponds to the non-enabled account selected in MetaMask.If a transaction is created with a nonce that is too low, it fails and generates errors. Conversely, if the nonce is set too high, the transaction remains in a
Pendingstate without displaying any error messages.Expected behavior
Screenshots/Recordings
nonce.mov
Steps to reproduce
Error messages or log output
No response
Detection stage
On the development branch
Version
develop
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: