Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use transaction address to get lock for custom nonce #28272

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 4, 2024

Description

Use transaction from address to get custom nonce value.

Related issues

Fixes: #28014

Manual testing steps

  1. Enable an account connected to the dApp
  2. Switch to non-enabled account in the MetaMask
  3. Initiate a transaction from the dApp
  4. Ensure correct nonce is displayed

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested review from a team as code owners November 4, 2024 17:12
Copy link
Contributor

github-actions bot commented Nov 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Nov 4, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1fa4d57]
Page Load Metrics (2210 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35226282122440211
domContentLoaded18022522217217182
load18482547221016680
domInteractive318651136
backgroundConnect1093362311
firstReactRender732121113115
getState667332110
initialActions01000
loadScripts13191959160915072
setupStore136730189
uiStartup20712829248419493
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 453 Bytes (0.01%)
  • common: -48 Bytes (-0.00%)

@sleepytanya
Copy link
Contributor

The subsequent transaction is created for the enabled account with the correct nonce value:

nonceFix.mov

@sleepytanya
Copy link
Contributor

These two bugs also look fixed by the current PR - #28239 and #27617

legacyTxNonceFix.mov

@jpuri jpuri added this pull request to the merge queue Nov 6, 2024
Merged via the queue into develop with commit f117f7c Nov 6, 2024
78 checks passed
@jpuri jpuri deleted the nonce_address_fix branch November 6, 2024 11:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-confirmations Push issues to confirmations team
Projects
None yet
5 participants