Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject eth_getEncryptionPublicKey for ledger hw wallets #10326

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

tmashuang
Copy link
Contributor

Fixes #10111

Determine if the msgParams/address for the newRequestEncryptionPublicKey is a ledger keyring via getKeyringForAccount and return a promise rejection.

Manual testing steps:

  • Connect a Ledger HW wallet
  • Attempt to get an encryption key for Ledger.
  • Should reject with the error message Ledger does not support eth_getEncryptionPublicKey.

Fixes #10111

Determine if the msgParams/address for the newRequestEncryptionPublicKey is a ledger keyring via getKeyringForAccount and return a promise rejection.
@tmashuang tmashuang requested a review from a team as a code owner February 1, 2021 19:47
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [746210a]
Page Load Metrics (714 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51946894
domContentLoaded43292271310751
load43392371410751
domInteractive43292271210751

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result

Tested with my Ledger, LGTM

@tmashuang tmashuang merged commit 23bab62 into develop Feb 1, 2021
@tmashuang tmashuang deleted the reject-ledger-eth_getEncryptionPublicKey branch February 1, 2021 20:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nothing returns or throws when ledger is trying to send eth_getEncryptionPublicKey
3 participants