Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject eth_getEncryptionPublicKey for ledger hw wallets #10326

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Reject eth_getEncryptionPublicKey for ledger hw wallets #10326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/scripts/metamask-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1643,6 +1643,13 @@ export default class MetamaskController extends EventEmitter {
* Passed back to the requesting Dapp.
*/
async newRequestEncryptionPublicKey(msgParams, req) {
const address = msgParams
const keyring = await this.keyringController.getKeyringForAccount(address)
if (keyring.type === 'Ledger Hardware') {
return new Promise((_, reject) => {
reject(new Error('Ledger does not support eth_getEncryptionPublicKey.'))
})
}
const promise = this.encryptionPublicKeyManager.addUnapprovedMessageAsync(
msgParams,
req,
Expand Down