Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version v12.2.3 RC #27066

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Version v12.2.3 RC #27066

merged 3 commits into from
Sep 11, 2024

Conversation

metamaskbot
Copy link
Collaborator

📦 🚀

metamaskbot and others added 2 commits September 11, 2024 15:37
@metamaskbot
Version v12.2.3
75fed52
@jpuri
fix (cherry-pick): Adding patch on eth-json-rpc-middleware to disable…
5eaa9d3 
… verifyContract field validation for cosmos (#27065)

Cherry-picks #27021
(4ee09fc)

## **Description**

Adding patch on eth-json-rpc-middleware to disable verifyContract field
validation for cosmos

## **Related issues**

Fixes: #26980

## **Manual testing steps**

1. Submit a types signature request with verifyingContract set to
`cosmos`
2. Ensure that you are able to sign it

## **Screenshots/Recordings**
<img width="360" alt="Screenshot 2024-09-10 at 4 08 00 PM"
src="https://github.com/user-attachments/assets/a56bb8bd-abed-4fae-9c50-a3a25addd5b5">

## **Pre-merge author checklist**

- [X] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Sep 11, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-block-tracker@9.0.3 None 0 64.5 kB lgbot
npm/@metamask/eth-json-rpc-provider@3.0.2 None 0 75.8 kB metamaskbot

🚮 Removed packages: npm/@metamask/eth-block-tracker@11.0.1, npm/@metamask/eth-json-rpc-middleware@14.0.1, npm/@metamask/eth-json-rpc-provider@4.1.3

View full report↗︎

@danjm
v12.2.3 changelog (#27073)
3611836 
Updates the changelog for v12.2.3
@metamaskbot
Copy link
Collaborator Author

Builds ready [5eaa9d3]
Page Load Metrics (1605 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25419231465434208
domContentLoaded12861905158519192
load12931953160519292
domInteractive13164424120

@danjm danjm mentioned this pull request Sep 11, 2024
Closed
@metamaskbot
Copy link
Collaborator Author

Builds ready [3611836]
Page Load Metrics (1788 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15421641712390188
domContentLoaded15862113176115474
load15942160178816177
domInteractive137935199

@danjm danjm marked this pull request as ready for review September 11, 2024 20:31
@danjm danjm requested a review from a team as a code owner September 11, 2024 20:31
@danjm danjm merged commit 086bb90 into master Sep 11, 2024
71 of 72 checks passed
@danjm danjm deleted the Version-v12.2.3 branch September 11, 2024 20:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metamaskbot @danjm @jpuri