Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move getInternalAccounts from selectors.js to accounts.ts #27645

Merged
merged 1 commit into from
Nov 4, 2024
Merged

refactor: move getInternalAccounts from selectors.js to accounts.ts #27645

merged 1 commit into from
Nov 4, 2024

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Oct 4, 2024 •
edited
Loading

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [80e8075]
Page Load Metrics (1785 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28625201730383184
domContentLoaded15932432177218689
load16012473178519292
domInteractive258844199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -1.14 KiB (-0.02%)
  • common: 2.38 KiB (0.03%)

@davidmurdoch davidmurdoch force-pushed the circles-006 branch 2 times, most recently from a82ad91 to f875d38 Compare October 8, 2024 18:05
@davidmurdoch davidmurdoch changed the base branch from circles-006 to circles-005 October 8, 2024 19:21
@davidmurdoch davidmurdoch changed the base branch from circles-005 to circles-006 October 8, 2024 20:59
@davidmurdoch davidmurdoch added the team-tiger Tiger team (for tech debt reduction + performance improvements) label Oct 9, 2024
@davidmurdoch davidmurdoch changed the title move getInternalAccounts from selectors.js to accounts.ts chore: move getInternalAccounts from selectors.js to accounts.ts Oct 9, 2024
@davidmurdoch davidmurdoch changed the title chore: move getInternalAccounts from selectors.js to accounts.ts refactor: move getInternalAccounts from selectors.js to accounts.ts Oct 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [baca2f5]
Page Load Metrics (1936 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38022861858372179
domContentLoaded16112268191314570
load16192278193614670
domInteractive2493552110
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -1.12 KiB (-0.01%)
  • common: 2.14 KiB (0.03%)

@davidmurdoch davidmurdoch marked this pull request as ready for review October 16, 2024 21:27
@davidmurdoch davidmurdoch requested review from a team as code owners October 16, 2024 21:27
@davidmurdoch davidmurdoch force-pushed the circles-006 branch 4 times, most recently from bb00b2c to 3f2a9e8 Compare October 30, 2024 16:14
@davidmurdoch davidmurdoch force-pushed the circles-007 branch 2 times, most recently from 96d49b7 to c377147 Compare October 30, 2024 19:00
@davidmurdoch davidmurdoch requested a review from a team as a code owner October 30, 2024 19:00
@metamaskbot
Copy link
Collaborator

Builds ready [c377147]
Page Load Metrics (1764 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26422151550550264
domContentLoaded15542148174015072
load15622222176416479
domInteractive167648178
backgroundConnect5103262311
firstReactRender44119852311
getState46012147
initialActions01000
loadScripts11481587128111656
setupStore1076282211
uiStartup17512501195818287
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -1.01 KiB (-0.01%)
  • common: 2.1 KiB (0.03%)

Base automatically changed from circles-006 to develop November 1, 2024 03:40
@davidmurdoch davidmurdoch changed the base branch from develop to migrate-textfield November 1, 2024 20:30
@davidmurdoch davidmurdoch requested review from a team and kumavis as code owners November 1, 2024 20:30
@davidmurdoch davidmurdoch changed the base branch from migrate-textfield to develop November 1, 2024 20:30
@metamaskbot
Copy link
Collaborator

Builds ready [c983298]
Page Load Metrics (1986 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17742246198712359
domContentLoaded17652187194610852
load17912250198612158
domInteractive179648199
backgroundConnect11112352813
firstReactRender51135102168
getState56219209
initialActions01000
loadScripts1263165314249646
setupStore1168282311
uiStartup19812422219612661
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 83 Bytes (0.00%)
  • common: 35 Bytes (0.00%)

@davidmurdoch davidmurdoch added this pull request to the merge queue Nov 4, 2024
Merged via the queue into develop with commit 77b77a8 Nov 4, 2024
76 checks passed
@davidmurdoch davidmurdoch deleted the circles-007 branch November 4, 2024 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2024
@Prithpal-Sooriya
fix: notification settings type (#28271)
18e81ba 
## **Description**

This fixes a poor type from converting a selectors file from JS to TS.
Instead of using a custom type for the accounts type, we can just use
inferred types.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28271?quickstart=1)

## **Related issues**

Fixes:
#27645 (comment)

## **Manual testing steps**

N/A these are only type level changes

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@shane-t shane-t shane-t approved these changes

@HowardBraham HowardBraham HowardBraham approved these changes

@kumavis kumavis Awaiting requested review from kumavis

Assignees
No one assigned
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-extension-platform team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@davidmurdoch @metamaskbot @HowardBraham @shane-t @DDDDDanica @GuillaumeRx @Prithpal-Sooriya