Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Create custom trace to measure performance of opening the account list #27907

Merged
merged 9 commits into from
Oct 18, 2024
Merged

perf: Create custom trace to measure performance of opening the account list #27907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a9a3480
Add new trace name for account list
MajorLift Oct 15, 2024
108f589
Define entry and exit points for custom trace
MajorLift Oct 15, 2024
9b44723
Fix `trace` import statement being wrapped in feature flag
MajorLift Oct 15, 2024
73aa946
add console logs to mark trace entry/exit
MajorLift Oct 15, 2024
fc93ecf
Revert "feat: codefence Account Watcher for flask (#27543)"
MajorLift Oct 9, 2024
b4e7667
Revert "fix: improve performance in account list and account connecti…
MajorLift Oct 16, 2024
ff60c3d
Revert "Revert "fix: improve performance in account list and account …
MajorLift Oct 16, 2024
b054892
Revert "Revert "feat: codefence Account Watcher for flask (#27543)""
MajorLift Oct 16, 2024
2f19f36
Revert "add console logs to mark trace entry/exit"
MajorLift Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shared/lib/trace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { log as sentryLogger } from '../../app/scripts/lib/setupSentry';
* The supported trace names.
*/
export enum TraceName {
AccountList = 'Account List',
BackgroundConnect = 'Background Connect',
DeveloperTest = 'Developer Test',
FirstRender = 'First Render',
Expand Down
12 changes: 11 additions & 1 deletion ui/components/multichain/account-list-menu/account-list-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import React, { useContext, useState, useMemo, useCallback } from 'react';
import React, {
useContext,
useState,
useMemo,
useCallback,
useEffect,
} from 'react';
import PropTypes from 'prop-types';
import { useHistory } from 'react-router-dom';
import Fuse from 'fuse.js';
Expand Down Expand Up @@ -99,6 +105,7 @@ import {
AccountConnections,
MergedInternalAccount,
} from '../../../selectors/selectors.types';
import { endTrace, TraceName } from '../../../../shared/lib/trace';
import { HiddenAccountList } from './hidden-account-list';

const ACTION_MODES = {
Expand Down Expand Up @@ -198,6 +205,9 @@ export const AccountListMenu = ({
}: AccountListMenuProps) => {
const t = useI18nContext();
const trackEvent = useContext(MetaMetricsContext);
useEffect(() => {
endTrace({ name: TraceName.AccountList });
}, []);
const accounts: InternalAccountWithBalance[] = useSelector(
getMetaMaskAccountsOrdered,
);
Expand Down
6 changes: 5 additions & 1 deletion ui/components/multichain/account-picker/account-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import { shortenAddress } from '../../../helpers/utils/util';
///: BEGIN:ONLY_INCLUDE_IF(build-mmi)
import { getCustodianIconForAddress } from '../../../selectors/institutional/selectors';
///: END:ONLY_INCLUDE_IF
import { trace, TraceName } from '../../../../shared/lib/trace';

export const AccountPicker = ({
address,
Expand Down Expand Up @@ -58,7 +59,10 @@ export const AccountPicker = ({
<ButtonBase
className={classnames('multichain-account-picker', className)}
data-testid="account-menu-icon"
onClick={onClick}
onClick={() => {
trace({ name: TraceName.AccountList });
onClick();
}}
backgroundColor={BackgroundColor.transparent}
borderRadius={BorderRadius.LG}
ellipsis
Expand Down