Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Portfolio button to BTC accounts #28184

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Oct 30, 2024

Description

Readds the "Portfolio" button for non-EVM accounts

Open in GitHub Codespaces

Related issues

Fixes: #26148 #28185

Manual testing steps

  1. Go to the Wallet page
  2. Switch to a BTC account
  3. The Portfolio button should be there

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jonybur jonybur requested a review from a team as a code owner October 30, 2024 15:07
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jonybur jonybur mentioned this pull request Oct 30, 2024
7 tasks
@seaona
Copy link
Contributor

seaona commented Oct 30, 2024

I see the issue fixed, thank you

flask-btc-portfolio.mp4

@metamaskbot
Copy link
Collaborator

Builds ready [5107e66]
Page Load Metrics (2070 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint81724591980309148
domContentLoaded17172436203317885
load17792462207017685
domInteractive20215614220
backgroundConnect978312412
firstReactRender601661042211
getState663262211
initialActions01000
loadScripts12611929152916378
setupStore1273302411
uiStartup19482685229218086
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -264 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants