support eth_chainId #5552
Merged
support eth_chainId #5552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get the real chainId using eth_chainId and use net_version as a fallback
kumavis
previously approved these changes
Oct 21, 2018
|
test failure likely fixed here #5569 |
kumavis
approved these changes
Oct 29, 2018
|
Sorry we had to roll this back to address #5664, we're going to work with Infura to get this back out asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support both
eth_chainIdandnet_versionnow we can get the real
chainIdfor signing.eth_chainIdmethod in JSON-RPC - EIP: Implementeth_chainIdmethod in JSON-RPC ethereum/EIPs#695 accepted(Aug 22 2017)eth_chainIdPR for Ethereum (geth) - eth,internal: add eth_chainId method to PublicEthereumApi JSONRPC ethereum/go-ethereum#15002, add eth_chainId method ethereum/go-ethereum#17617 merged(9/9)eth_chainIdPR for ETC (classic-geth) - implement 'eth_chainId' JSON-RPC method ethereumproject/go-ethereum#336 merged(Aug 16 2017)parity_chainIdPR - Add RPC eth_chainId for querying the current blockchain chain ID openethereum/parity-ethereum#6329 merged (Aug 18 2017)parity_chainIdtoeth_chainIdSupport eth_chainId RPC method openethereum/parity-ethereum#9783 merged(10/21)